Giter VIP home page Giter VIP logo

Comments (4)

coruscating avatar coruscating commented on June 12, 2024 1

This is good to know, I'll update the experiments docs to remove the drop shadow from cards. Do you know why these elements in carbon have shadows when others don't? Is there a general rule for when to add shadows?

image

from qiskit_sphinx_theme.

javabster avatar javabster commented on June 12, 2024 1

these elements are "toasts", which means they are designed to pop up in front of the screen and the user can close them. The drop shadow here is an intentional design choice to show there is depth to the page and that there may be stuff behind it that the user might want to uncover by closing the toast.

So i think a general rule of thumb is any element that is a permanent fixture on the page should not have a dropshadow, but things like notifications and cookie warnings that are closable can have them

from qiskit_sphinx_theme.

javabster avatar javabster commented on June 12, 2024

update: I realised we also have drop shadows for the cards and dropdowns, these should also use the flat carbon design system. Additionally, these 2 components have slightly rounded radius, the should have border-radius:0
Screenshot 2023-06-06 at 5 11 47 PM
Screenshot 2023-06-06 at 5 11 53 PM

from qiskit_sphinx_theme.

javabster avatar javabster commented on June 12, 2024

same for admonitions. Dropshadow should be removed and border radius should be 0
Screenshot 2023-06-06 at 5 17 09 PM

We should also make sure these colours are the right ones for IBM/Qiskit.

IBM carbon equivalent: https://carbondesignsystem.com/components/notification/style

from qiskit_sphinx_theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.