Giter VIP home page Giter VIP logo

Comments (4)

henryiii avatar henryiii commented on July 16, 2024

Note: In cibuildwheel, regardless of what the current documentation seems to claim, MACOSX_DEPLOYMENT_TARGET is not set automatically, and it generally always should be set by hand.

from rustworkx.

mtreinish avatar mtreinish commented on July 16, 2024

Thanks for the suggestion, I wasn't aware of that env variable. As a non-mac user I wasn't sure how to control the compat level and the reason for the different wheels on the current version on pypi was ci env differences (azure pipelines vs travis). I agree we should do this as I want to make sure we offer widely compatible wheels for as many platforms as we can for this (the nightly rustc requirement is difficult for some users unfamiliar with the rust ecosystem). I'll push up a pr tomorrow to experiment with setting that env variable in the cibuildwheel environment to see if I can get it to build wheels targeting 10.9.

from rustworkx.

mtreinish avatar mtreinish commented on July 16, 2024

Ok, I've pushed up a PR (#63) to fix this. I also pushed up test commit to manually trigger the macOS wheel builds to test this. Based on the output of the ci job it looks like it's working:

https://dev.azure.com/qiskit-ci/retworkx/_build/results?buildId=11655&view=logs&j=59072c2d-ff9c-5ba9-5217-fae5d67698fb&t=e64845d4-b26a-5b36-9ae2-80aaa975f01a&l=523

If you want to test the wheels built by the job are hosted here: https://dev.azure.com/qiskit-ci/retworkx/_build/results?buildId=11655&view=artifacts&type=publishedArtifacts (there is a download icon that will appear when you hover your mouse over the drop line, the azure pipelines ui leaves something to be desired) if you want to verify that these work on an older macOS version. Once the PR merges I will soon push out a 0.3.4 release to get the updated wheels on pypi.

from rustworkx.

mtreinish avatar mtreinish commented on July 16, 2024

Just wanted to leave a note here, the 0.3.4 release is up on pypi now: https://pypi.org/project/retworkx/0.3.4/#files and the macOS wheels were built with a 10.9 target so local compilation should no longer be required to install the package on older versions of macOS.

from rustworkx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.