Giter VIP home page Giter VIP logo

Comments (6)

SpertsyanKM avatar SpertsyanKM commented on June 1, 2024 1

Hello! Sorry for the late response.

We have researched your case and found the issue. You are right - now, with the described scenario, there is an issue that the logged-out user will get cached permissions even if his own identify call fails.

We have fixed this bug already and it will be released soon.

Also, I want to let you know that we are now working on the new major versions of our SDKs, where all the network calls (and identify calls either) will obviously throw exceptions if something goes wrong. And all the SDKs logic will be more obvious and understandable.

from flutter-sdk.

pixelfoxxx avatar pixelfoxxx commented on June 1, 2024 1

Hello @rwrz! Thank you for waiting.

We want to notify you that we've released the new version of SDK, where we've fixed the issue you're mentioning.

Let us know if you have any further questions or if the issue persists. We'll be glad to assist!

from flutter-sdk.

suriksarkisyan avatar suriksarkisyan commented on June 1, 2024

Hi, @rwrz .
Continuing our discussion from the support chat, I want to make some updates here. As I said, the problem is already solved. What about failed identity response and throwing an error? You are right; we are not throwing any error now because we are not sure it's useful for our users. Besides, when the identity request fails, and you ask for user permissions, we try to resend the identity request and get the most actual permissions. So you will get correct permissions (or error on permissions requests) even if the first identity request fails.

from flutter-sdk.

rwrz avatar rwrz commented on June 1, 2024

Permission request you mean here? Qonversion.checkPermissions())
It is not throwing errors to me. =/

from flutter-sdk.

suriksarkisyan avatar suriksarkisyan commented on June 1, 2024

Permission request you mean here? Qonversion.checkPermissions())
It is not throwing errors to me. =/

Yes, that one. That function should throw an error when it occurs, and if you added try and catch blocks. Our SDK is trying to get correct permissions (from cache or server) and return them. If it's not possible, the SDK will return an error.

from flutter-sdk.

rwrz avatar rwrz commented on June 1, 2024

Follow me on this:

  • User A sign-in, we do a QOnversion.identify(), it works
  • Then we retrieve his permissions with Qonversion.checkPermissions(), it works
  • Now User A sign-out (logout)
  • User B sign-in, and QOnversion.identify() fails

Should Qonversion.checkPermissions() throw an error or retrieve permissions from the cache with User A permissions?

Because, I'm almost sure that right now it just returns the wrong permissions and since it doesn't throw any exceptions, anywhere, I'm not able to identify that his permissions are wrong.

I was considering to use .launch instead. It throws errors, but seems wrong and I'm not sure how it will handle the user SignIn and SignOut.

from flutter-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.