Giter VIP home page Giter VIP logo

Comments (16)

Qoraiche avatar Qoraiche commented on May 20, 2024 2

Hi @salhdev,
Thanks for reporting this I will take this into consideration in the next updates,

Also, PRs are welcome 👍

Thanks again.

from laravel-mail-editor.

griffins avatar griffins commented on May 20, 2024 1

Its because of where the files are being stored. sorry about that. @keatwei Once we get my PR merged that would be fixed

from laravel-mail-editor.

keatwei avatar keatwei commented on May 20, 2024 1

@griffins ya.. if possible can put in resources/views/emails would be great
thx for your effort and package

from laravel-mail-editor.

griffins avatar griffins commented on May 20, 2024 1

For the second task there is PR #13 which should fix known issues preventing the package from being used in production

from laravel-mail-editor.

Qoraiche avatar Qoraiche commented on May 20, 2024 1

@griffins thanks for your PRs I will take a look at it tomorrow when I come back home.

Thanks again.

from laravel-mail-editor.

griffins avatar griffins commented on May 20, 2024

Exactly what i was wondering

from laravel-mail-editor.

griffins avatar griffins commented on May 20, 2024

Just found out about this package today from laravel news. I love it.
My only problem is the need to modify my database schema. I would love if the package could maintain its meta data in a json file instead of the db. Am willing to make a pr for the same

from laravel-mail-editor.

griffins avatar griffins commented on May 20, 2024

Am doing a PR for this issue, what do you think about the views existed in the default namespace instead of the maileclipse one?

from laravel-mail-editor.

griffins avatar griffins commented on May 20, 2024

Hi i did a PR for the first task. #11

from laravel-mail-editor.

keatwei avatar keatwei commented on May 20, 2024

after i do composer update, my existing template is not accessible

from laravel-mail-editor.

griffins avatar griffins commented on May 20, 2024

Also if you drop your database you will lose them

from laravel-mail-editor.

griffins avatar griffins commented on May 20, 2024

I already did that. Actually you can customize the folder you want

There is a new config for it.

like here

    'view' => [
        'dir' => resource_path('views/mail/'),
        'namespace' => 'mail'
    ],

from laravel-mail-editor.

dbfx avatar dbfx commented on May 20, 2024

Any word on a plan to make this easy to migrate into production?

from laravel-mail-editor.

Qoraiche avatar Qoraiche commented on May 20, 2024

Hello @dbfx, @salhdev, @keatwei

Please update to the latest version (currently 1.1.7), now you can override templates views using the following publish command:

php artisan vendor:publish --tag=maileclipse.templates

Also, there is no need for database migration, all templates metadata will be stored in a JSON file.

hope this helps,
Thanks

from laravel-mail-editor.

dbfx avatar dbfx commented on May 20, 2024

Great thank you! Sent a contribution to the project from Snapt!

from laravel-mail-editor.

Qoraiche avatar Qoraiche commented on May 20, 2024

@dbfx thank you so much, I appreciate it!

from laravel-mail-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.