Giter VIP home page Giter VIP logo

Comments (3)

benny-n avatar benny-n commented on May 19, 2024

This also somewhat bothered me, it does make development with a lot of re-builds a little annoying.
A very simple solution would be to add

#![allow(unused)] // TODO remove it when the code is stable

to both /src/main.rs and /dump-parser/src/lib.rs as the 1st line, and all those warnings will be gone.

from replibyte.

pascalgrimaud avatar pascalgrimaud commented on May 19, 2024

I opened this ticket as I'm trying to learn Rust, and would like to contribute :-)
So I can clean all these warnings in different pull requests, but I wanted to be sure if it's intended (for future features) or it's just some missing cleaning during development.

I could do some small PRs (one for each warning) and you could accept or decline, depending on the need of variables / functions. What do you think?

from replibyte.

benny-n avatar benny-n commented on May 19, 2024

@pascalgrimaud It's great that you want to learn Rust and contribute and I'd be happy to help with what I can 🙂
It's just that most of these warnings as you can see are only due to unused variables or structs, which will only be utilized in the future of the crate development.
So basically cleaning these warnings just means to keep developing the crate :)

from replibyte.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.