scribble seems to be broken about scripts HOT 17 CLOSED

For me the generated ![scribble](media/341084995.png) works just fine. All your points "Expected behaviour" work for me

but in the next line you are trying to replace "file://media" which (as far of my understanding) will never match.

It acts as fallback for the legacy method of linking media files (it was the main method until a few weeks ago).

question link gets inserted but looks like this , shouldn't there be a "file://"?

not any more (since a few weeks)

from scripts.

external editor gets opend with full image path as parameter

that didn't work, I just ctrl+clicked the image markdown in the editor

from scripts.

Are you up for the task, @bessw? 💪

from scripts.

I'm not shure what parts of the code you want to be switchable to lagacy version.
But I will try to fix it.

from scripts.

Sorry, I previously linked the wrong line in the script, this one is correct:

The current script works if you enable the "legacy way of inserting links" in the QON settings. In order to be able to open the external application with the correct file the path to the file needs to be generated in a different way.

from scripts.

You can do that by using currentNote().fullNoteFilePath or playing with the current note folder and note sub-folder path, but I will add a new property fullNoteFileDirPath for NoteApi to get the absolute directory path of the a note file in the next release.

from scripts.

19.10.8

• there now is a new method getFileURLFromFileName() for NoteApi to get the
  absolute file url from a relative file name
  • for more information please take a look at
    scripting documentation
• there now is a new property fullNoteFileDirPath for NoteApi to get the
  absolute directory path of the a note file
  • for more information please take a look at
    scripting documentation

from scripts.

There now is a new release, you could use fullNoteFileDirPath now.

from scripts.

And don't forget to bump the minAppVersion in https://github.com/qownnotes/scripts/blob/master/scribble/info.json if use are using the new property. 😄

from scripts.

If updated the script now. 😄 Does it work for you?

from scripts.

I've still got problems with it.

First of all since I'm on Windows I needed to add script.toNativeDirSeparators(mediaFilePath).

But the weird thing is for some reason I needed to replace script.getApplicationSettingsVariable("legacyLinking") with false to test the new behaviour, but when I print script.getApplicationSettingsVariable("legacyLinking") to the console it also returns false 😕

from scripts.

script.getApplicationSettingsVariable("legacyLinking") seems to return false as string instead of boolean.

Comparing to "false" would fix this here, or is this a bug of script.getApplicationSettingsVariable("legacyLinking") and you want to fix it there?

from scripts.

First of all since I'm on Windows I needed to add script.toNativeDirSeparators(mediaFilePath).

great, just add that

script.getApplicationSettingsVariable("legacyLinking") seems to return false as string instead of boolean.

strange, it worked fine on Linux, getApplicationSettingsVariable will return some kind of QVariant, maybe comparing it to a string would be more safe

do you want to create a pull request with the changes?

from scripts.

Yes, wait a sec.

from scripts.

I bumped the version for you. Can you please check if the script works for you in the script repository.

from scripts.

workes ✔️

from scripts.

Great! Thank you

from scripts.