center-alignment for figures dismissed in Jupinx about lecture-source-py HOT 9 CLOSED

@mmcky I suggest we default to centred images and also set a max-width (addressing @fkazemian figures too big above). I've added a few styles to the compare site to address this.

from lecture-source-py.

thanks @fkazemian it looks like JupyterLab and Jupyter Notebook rendering differ on this. The same images test notebook are rendering differently.

from lecture-source-py.

for each of these reports can you please add the lecture name to the description to help me locate the cases. Thanks.

from lecture-source-py.

@fkazemian since we updated nbconvert do you still see oversized images on your end?

from lecture-source-py.

@DrDrij we do have support for figure alignment pass through in the jupinx extension - it is just that none of the source files are using it at the moment. I could pretty easily setup a jupyter_align_figure global to change the default alignment to "center" when writing the figures in html in the notebook. I am just wondering if you think this should be done at the theme level. The reason I ask is if I do this task in jupinx for figures included in the markdown this may not catch figures generated in the executed notebooks.

from lecture-source-py.

• implement a global in jupinx to center included figures in markdown blocks, or
• change to default centered images in the quantecon template / theme

from lecture-source-py.

Hi @mmcky
I just checked career.html and I still can see some figures are too big

from lecture-source-py.

thanks @DrDrij I will add you as a collaborator to the repo that I am putting together to assemble all of these things through the various stages. Would you mind adding your css etc.

from lecture-source-py.

thanks @DrDrij. I am closing this as I think this is now fixed based on compare-lectures.quantecon.org.
I have opened https://github.com/mmcky/quantecon.build.lectures/pull/6 to add css into the build chain but can update that branch from the compare-lectures if that is easier.

from lecture-source-py.