Giter VIP home page Giter VIP logo

Comments (3)

quantombone avatar quantombone commented on July 16, 2024

Thanks Amir for catching this!

I might have already fixed this issue in my development branch as I've refactored a lot of things. I haven't pushed any changes into the main branch because people started using it and I don't have enough time to always make sure it is stable.

I've been slow on replying because I stopped having github email me notifications and they've changed their interface a bit (so it took me a few days to notice I have notifications pending!)

from exemplarsvm.

quantombone avatar quantombone commented on July 16, 2024

Hey Amir, do you know how to do pull requests in github? The idea is that you can for my code, fix your own fork. Then if you think that your fix is worthy of spreading to my master branch, you submit a pull request. I believe that way you get credited with the bugfix/extension and it helps everybody out.

I would love to part-take in more forking, branching, etc. The catch is that you have to perform the pull requests with one fix at a time, so that I can clearly see what you changed. Let me know if you're interested in doing things this way.

from exemplarsvm.

rosenfeldamir avatar rosenfeldamir commented on July 16, 2024

Hi Tomasz,
I'm not really familiar with how to work with github. I'll take the time to
get acquainted to it if I find more stuff that I'd like to change. For the
meantime, I don't mind if I don't get credit (or blame..) for this change.

Cheers,
-Amir

On Fri, Aug 10, 2012 at 10:24 AM, Tomasz Malisiewicz <
[email protected]> wrote:

Hey Amir, do you know how to do pull requests in github? The idea is that
you can for my code, fix your own fork. Then if you think that your fix is
worthy of spreading to my master branch, you submit a pull request. I
believe that way you get credited with the bugfix/extension and it helps
everybody out.

I would love to part-take in more forking, branching, etc. The catch is
that you have to perform the pull requests with one fix at a time, so that
I can clearly see what you changed. Let me know if you're interested in
doing things this way.


Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-7635877.

from exemplarsvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.