Comments (4)
@benfdking & @gvozdvmozgu to review
from sqruff.
A few of my thoughts/opinions that are running through my mind
I would start by not deviating from anything that sqlfluff
does. In my mind, our V1 should still try to be as close as possible in terms of fidelity. Even if that is sub-ideal long-term, it just makes it easier to test/debug/develop when we have a clear comparison point.
For V2 and having achieved some parity, I think it's important that the rule options become more strict in code. The options at the moment are in maps and I think letting each rule define its parameters, as well as any rule cross dependencies and what it can take, will make the project much easier to debug at scale.
For example, at the moment, we have a default config that is a [toml] file. I think we should be able to generate a file from each rule that gives it its "default."
I think we should then try to move away as much as possible from maps into strict types that make the project feel more robust and probably also more performant. Once those things are in place, I think it will then be much easier to move defaults and then try to part ways with sqlfluff
.
from sqruff.
It seems this is already implemented? At least version 1, as described above
from sqruff.
👍
Happy to close. @louisjoecodes ?
from sqruff.
Related Issues (20)
- Brew - download link is broken HOT 6
- Build easy to use docker images
- Add descriptions to the rules in a callback method so we can generate the description page of them eventually HOT 2
- Pin Rust version that we are building with
- Adding --help command that doesn't fail with some config unwrap
- `serde_yaml` was deprecated
- Bad lints in dialect BigQuery: Double AS and removing a
- Bug: Bad deleting of AS in BigQuery HOT 1
- Lint output when everything is ok
- Compile the `lib` crate in wasm32-unknown-unknown in CI
- Potential optimizations HOT 6
- [Dialect] Implement PostgreSQL Dialect support HOT 3
- [Dialect] Implement Snowflake Dialect support
- Getting Error "not implemented" when running sqruff lint HOT 6
- [Dialect] Implement Clickhouse dialect
- Update install instructions to avoid the following
- [Docs] Build a docs/readme page from the code base.
- [Dialect] DuckDB dialect
- VS Code extension
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqruff.