Giter VIP home page Giter VIP logo

Comments (4)

louisjoecodes avatar louisjoecodes commented on June 12, 2024

@benfdking & @gvozdvmozgu to review

from sqruff.

benfdking avatar benfdking commented on June 12, 2024

A few of my thoughts/opinions that are running through my mind

I would start by not deviating from anything that sqlfluff does. In my mind, our V1 should still try to be as close as possible in terms of fidelity. Even if that is sub-ideal long-term, it just makes it easier to test/debug/develop when we have a clear comparison point.

For V2 and having achieved some parity, I think it's important that the rule options become more strict in code. The options at the moment are in maps and I think letting each rule define its parameters, as well as any rule cross dependencies and what it can take, will make the project much easier to debug at scale.

For example, at the moment, we have a default config that is a [toml] file. I think we should be able to generate a file from each rule that gives it its "default."

I think we should then try to move away as much as possible from maps into strict types that make the project feel more robust and probably also more performant. Once those things are in place, I think it will then be much easier to move defaults and then try to part ways with sqlfluff.

from sqruff.

gvozdvmozgu avatar gvozdvmozgu commented on June 12, 2024

It seems this is already implemented? At least version 1, as described above

from sqruff.

benfdking avatar benfdking commented on June 12, 2024

👍

Happy to close. @louisjoecodes ?

from sqruff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.