Giter VIP home page Giter VIP logo

Comments (3)

pauljohanneskraft avatar pauljohanneskraft commented on May 28, 2024

I'm not sure I understand what you mean - can you elaborate on how adding another protocol will solve memory issues? A method would need to be called at some point - that cannot easily be done. An alternative would be to enable overriding of canBeRemovedAsChild. Feel free to open a MR once you have a working version, so we can start a discussion on how to solve this best.

from xcoordinator-example.

pauljohanneskraft avatar pauljohanneskraft commented on May 28, 2024

The leak in AboutCoordinator can easily be fixed by overriding the viewController property with:

override var viewController: UIViewController! {
    rootViewController.viewControllers.first { $0 is AboutViewController }
}

I will open a MR today for that.

from xcoordinator-example.

calvingit avatar calvingit commented on May 28, 2024

Me too. Even build with XCoordinator v2.2.0, the child coordinator can't be removed when clicked the navigation bar back button. I have tried the way from @pauljohanneskraft , it works.

from xcoordinator-example.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.