Giter VIP home page Giter VIP logo

Comments (18)

quietvoid avatar quietvoid commented on June 12, 2024 1

If you have the source you should just be using the RPU for the encode.

Otherwise you extract the RPU and use the command in the readme:
dovi_tool inject-rpu -i x265-encode.hevc --rpu-in RPU.bin

from dovi_tool.

quietvoid avatar quietvoid commented on June 12, 2024 1

Probably not given both MKVToolNix and MediaInfo have no issue with the file.

from dovi_tool.

koolkunz avatar koolkunz commented on June 12, 2024

Sorry to bother you again, one more small question regarding this, what to do in case of an existing cropped black bars h265 hdr10 encode ? I know I need to use the --crop flag but not sure exactly how to use it?

from dovi_tool.

quietvoid avatar quietvoid commented on June 12, 2024

If you are using metadata for a cropped encode, you should be using --crop either when extracting or when editing.
Example for editing (mode 2 AND crop): https://github.com/quietvoid/dovi_tool/blob/main/assets/editor_examples/crop.json

from dovi_tool.

koolkunz avatar koolkunz commented on June 12, 2024

so I should use the crop flag when extracting RPU from the remux/blu ray disc source and then later inject that rpu into the cropped encode without using the crop flag, right?

from dovi_tool.

quietvoid avatar quietvoid commented on June 12, 2024

The crop flag doesn't affect the inject-rpu command, so yes.

from dovi_tool.

koolkunz avatar koolkunz commented on June 12, 2024

ok I think I got it.. thanks !

from dovi_tool.

koolkunz avatar koolkunz commented on June 12, 2024

dovi_tool inject-rpu -i x265-encode.hevc --rpu_in RPU.bin Parsing RPU file... Processing input video for frame order info... thread 'main' panicked at 'Number of frames of input and RPU file are different!', src\dovi\rpu_injector.rs:140:17 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

getting this when both the video files are of exact same length. source is a remux, destination is a hdr10 encode

from dovi_tool.

quietvoid avatar quietvoid commented on June 12, 2024

See this issue for info: #19

from dovi_tool.

koolkunz avatar koolkunz commented on June 12, 2024

Ah, okay I was using gmkvextractgui only. Will procede with ffmpeg from now on.

from dovi_tool.

manuelrn avatar manuelrn commented on June 12, 2024

@quietvoid I have a question related to this topic.

If starting from an HDR encode in MKV, not HEVC file. Would it be appropriate to get that HEVC file from the MKV with a UsEac3to demux? (I have doubts after seeing issue #19 with gMKVExtractGUI)

Or could it just do everything at once with ffmpeg?
Something like that:
ffmpeg -i file.mkv -c:v copy -vbsf hevc_mp4toannexb -f hevc - | dovi_tool inject-rpu -i - --rpu-in "file_RPU.bin"

And finally, how do I proceed with the resulting file?
Is it necessary to open the file with MakeMKV and then save it again before loading it into MKVToolNix?

I say it because for a long time I think it was necessary to do this, but I have seen that recently you have contributed some commits in the MKVToolNix project that help the implementation of Dolby Vision. Then I don't know if now it could be used directly in MKVToolNix without first using MakeMKV.

Thanks and regards!

from dovi_tool.

quietvoid avatar quietvoid commented on June 12, 2024

Injecting cannot be used with piping, because it relies on the whole decoded order for interleaving metadata.

You can just use ffmpeg to demux, like this: ffmpeg -i file.mkv -c:v copy video.hevc
And then run dovi_tool using the HEVC bitstream.

After injecting, you can mux the final file to MKV using MKVToolNix v58.
There's no need for MakeMKV.

from dovi_tool.

manuelrn avatar manuelrn commented on June 12, 2024

Okay, thank you very much for your quick reply!
Regards!

from dovi_tool.

koolkunz avatar koolkunz commented on June 12, 2024

@quietvoid I tried doing this for a movie (Scott Pilgrim vs the World). Extracted rpu from remux with crop flag using:
dovi_tool -c -m 2 extract-rpu source.hevc

then injected that rpu into an hdr10 encode using:
dovi_tool inject-rpu -i x265-encode.hevc --rpu-in RPU.bin

and then muxed the hevc file back to mkv along with audio and subtitles using mkvtoolnix. And the resultant file shows dovi profile 8 in mediainfo, but the file does not play via plex.

Anything I am doing wrong here? (the hevc files have been extracted using ffmpeg command: ffmpeg -i title_t00.mkv -c:v copy video.hevc)

from dovi_tool.

quietvoid avatar quietvoid commented on June 12, 2024

I don't know, ask Plex.

from dovi_tool.

koolkunz avatar koolkunz commented on June 12, 2024

It is not just about plex, the file doesnt play on other video players also on an android tv. I just mentioned plex because that is what most people use to play dovi files.

from dovi_tool.

quietvoid avatar quietvoid commented on June 12, 2024

What do you expect me to do? You didn't provide any sample.
If MediaInfo detects it the problem isn't coming from here.

from dovi_tool.

koolkunz avatar koolkunz commented on June 12, 2024

Ok thats my bad but I was just asking if anything wrong with the steps I have taken.

from dovi_tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.