Green frames sometimes about dovi_tool HOT 13 CLOSED

I had a quick look at the metadata order after encoding, and the order varies depending on the encode settings.
There's not much I can fix here, the metadata insertion is dependent on x265.

For example, default settings end up with a lot of difference between original RPU order and extracted from reencode.
With --ref 6 --bframes 16, there are less differences in the order but the issue is still present on playback.

The same issue happens with HDR10+ metadata.
It might be possible to reorder properly in x265's code but it would probably never end up upstream.

As far as I know there aren't many noticeable issues with out of order metadata in most cases, so this kind of scene might be one of those.
There's no use in matching the order for the source file, because it won't match the reencode (with the current x265 behavior) anyways.

from dovi_tool.

If mode 0 doesn't have any error, there is no bug.
If you have encoded a different resolution than what is coded into the RPU (for example, cropping), it is possible that the image is incorrect on playback.

from dovi_tool.

No I didn’t crop at all.

I will do another test but what is the correct extract_rpu mode if I want to encode with dolby vision profile 8.1 in x265 ? Mode 0 or mode 2 ? (I chose mode 2 at the beginning because the readme says that mode 2 is for profile 8.1 but maybe I’m wrong...)

from dovi_tool.

Mode 2 is correct for profile 8.1, mode 0 is only for verifying the parsing is correct first.
There shouldn't be issues introduced by the conversion, from my tests.

Might be a decoder issue if it's not all the time, or something wrong in the RPU in the first place if it's reproducible at the same frames in the source video.

from dovi_tool.

Ok thank you for your response and thank you for your work ! I will test that again. The issue is not reproducible in the source video in this case. It's really strange because I only see this issue in black screens, for example a black screen with just a white text in it. The white text becomes green just before the cutscene... But yes it can be a decoder issue...

from dovi_tool.

No idea, these kind of issues can't really be debugged because all the processing on playback is proprietary, so who knows what is wrong.

There's no specification on the different profiles either, so I can't confirm whether it's an issue with the conversion or not without testing myself.
Can you share a sample with which the issue can be reproduced? Or the title you reencoded with a timestamp of when the issue occurs?

from dovi_tool.

Yes of course, here is a 2 minutes sample where I can reproduce the issue : https://uptobox.com/ic7q7p5btf51

The issue is visible at about 1:33 where we can see the white texts. All the film is ok for me except for this scene and another one (another black screen with just a small object in the middle).

Let me know if you have the same issue, I just did another test and I reproduced it...

from dovi_tool.

I can only reproduce when reencoding, there might be a slight desync caused by x265.
With a converted RPU only, there's no green flashing.

The only solution would be to reorder the frame metadata according to presentation order, instead of the order in which they're parsed from the file.
I'm not sure when I'll have the time to look into that.

from dovi_tool.

Thank you for your tests, I understand the issue now.

No problem if you don’t have time to look into that for now, you already do an incredible job with your tools so we know it takes time :)

from dovi_tool.

I've reopened this because I think it's feasible to output the correct order.
x265 just outputs differently because the frame order changes, but the presentation order is the same.

from dovi_tool.

I'm glad to read that, I really appreciate your work.

Do you think hdr10plus_parser has the same "issue" and needs the same update ? (decode order vs presentation order)

from dovi_tool.

Yes

from dovi_tool.

Should be fixed in 0.2.0, I can get identical metadata before and after encode.
And the sample does not flicker green anymore.

from dovi_tool.