Giter VIP home page Giter VIP logo

Comments (5)

QuiiBz avatar QuiiBz commented on July 29, 2024 1

Oh I understand what you mean now, sorry. I'll make another fix for it.

from next-international.

QuiiBz avatar QuiiBz commented on July 29, 2024

Thanks, I've just released 0.9.2 which fixes the type bug. You could already pass a config parameter but the type was wrong.

from next-international.

roux1max avatar roux1max commented on July 29, 2024

Awesome! Thanks!

In the same spirit, getStaticParams does not take a config param to change the segment name which means that if you use a segment name that is different than "locale", it won't work.

from next-international.

QuiiBz avatar QuiiBz commented on July 29, 2024

getStaticParams doesn't need the segment name, as it uses directly the keys of the locales object from createI18nServer:

export function createGetStaticParams<Locales extends ImportedLocales>(locales: Locales) {

from next-international.

roux1max avatar roux1max commented on July 29, 2024

It does, the key returned by each object in the array is 'locale', which will match the path segment as per NextJs documentation.

In order for createGetStaticParams to work, it would need to be changed to something like this:

export function createGetStaticParams<Locales extends ImportedLocales>(locales: Locales) {
  return function getStaticParams(config?: I18nCurrentLocaleConfig) {
    return Object.keys(locales).map(locale => ({
      [config?.segmentName ?? DEFAULT_SEGMENT_NAME]: locale,
    }));
  };
}

from next-international.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.