Giter VIP home page Giter VIP logo

Comments (11)

JamesMGreene avatar JamesMGreene commented on June 12, 2024

Thanks for reporting this!

Yeah, that is all around messed up... especially since it's going to the jQuery core API docs.

Correct link should be: http://api.qunitjs.com/QUnit.assert/

from api.qunitjs.com.

JamesMGreene avatar JamesMGreene commented on June 12, 2024

Seems that we need to override some of the base XSL templates from grunt-jquery-content. I would be surprised if this isn't causing documentation bugs in jQuery UI, Mobile, Sizzle, etc.

from api.qunitjs.com.

leobalter avatar leobalter commented on June 12, 2024

I tried to link the assert argument to it's reference object, that is QUnit.assert. But that was wrong because that need to be exactly the JS type.

That would make sense if we already had an instantiation of QUnit's Assert, but it's not the case here.

To quick fix this I pushed #56 to set the correct type of assert.

from api.qunitjs.com.

jonvuri avatar jonvuri commented on June 12, 2024

if we already had an instantiation of QUnit's Assert

I must be misunderstanding something, because I thought this was exactly the case. That's the signature of the callback, by the time it is called QUnit.assert certainly will have been instantiated and passed to it.

from api.qunitjs.com.

leobalter avatar leobalter commented on June 12, 2024

Yes, I explained it wrong here.

I'm just focused on qunitjs/qunit#588 and was trying to refer to that. My bad.

from api.qunitjs.com.

jonvuri avatar jonvuri commented on June 12, 2024

I'm not sure I understand the full import of that, but from an outsider's perspective it's not ideal to not have a link to QUnit.assert there. (The one you just removed in #56) That's an important link to be able to know what you can do with that object.

from api.qunitjs.com.

leobalter avatar leobalter commented on June 12, 2024

@jzaefferer and @scottgonzalez: there's any possibility to set a custom link to custom argument types there?

@jrajav: let's see if we can improve/implement it.

from api.qunitjs.com.

jzaefferer avatar jzaefferer commented on June 12, 2024

Let's put a link to the relevant page or category in the description of those methods.

from api.qunitjs.com.

scottgonzalez avatar scottgonzalez commented on June 12, 2024

I would be surprised if this isn't causing documentation bugs in jQuery UI, Mobile, Sizzle, etc.

Why? None of the other projects use custom types.

from api.qunitjs.com.

scottgonzalez avatar scottgonzalez commented on June 12, 2024

there's any possibility to set a custom link to custom argument types there?

There's no support for custom types. I've created jquery/grunt-jquery-content#54 for discussion around the idea.

from api.qunitjs.com.

jzaefferer avatar jzaefferer commented on June 12, 2024

I created a follow-up ticket for this, to implement a better solution, #58.

from api.qunitjs.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.