Giter VIP home page Giter VIP logo

Comments (5)

scottgonzalez avatar scottgonzalez commented on June 12, 2024

I think this may just be a bad example. CustomError should inherit from Error, but it doesn't.

from api.qunitjs.com.

Krinkle avatar Krinkle commented on June 12, 2024

On QUnit v1.14.0 it fails with a TypeError indeed (the case of "expected" being an object is handled, but only by accident). With the latest pre build from GitHub, it fails even worse.

Expected:   
{
  "message": "some error description",
  "message": "some error description",
  "toString": function( ){
    [code]
  }
}
Source:     
    at Object.QUnit.assert.Assert.throws (https://code.jquery.com/qunit/qunit-git.js:1139:9)

It falls straight through all the different if conditions with no useful error. I think this is a valid bug. There is no reason why the object needs to be an instance of Error. The assert.throws signature would't become ambiguous. And it would support asserting thrown plain objects, which is neat.

Filed qunitjs/qunit#609.

from api.qunitjs.com.

Legends avatar Legends commented on June 12, 2024

Either the docu or the API has to change.
Which way will we go?

from api.qunitjs.com.

leobalter avatar leobalter commented on June 12, 2024

The API is about to be fixed on qunitjs/qunit#610, @Legends. We're going to keep this issue open until we land that.

from api.qunitjs.com.

JamesMGreene avatar JamesMGreene commented on June 12, 2024

Fixed by @Krinkle in the current codebase (will be released in v1.15).

from api.qunitjs.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.