RMySQL fails build with mariadb >10.4 about rmysql HOT 12 OPEN

Fixed in this pull request:

#215

from rmysql.

Any chance this can be pushed? I'm still seeing this error in CentOS 7.4, R 3.4.2 and MariaDB 10.2.11.1

from rmysql.

@datakid Meanwhile you can use my fork with install GitHub from devtools.

from rmysql.

Ah yeah. I might do. The RMariadb package installed - but the package I'm trying to install needs RMySQL and it's written poorly enough that I'd rather not fix it myself.

from rmysql.

@datakid My fork is from RMySQL master, to install it , you have to first install devtools from R package manager:

install.packages("devtools")

Then you will able to install RMySQL from my fork using the devtools (works on gentoo linux with latest mariadb beta too).

devtools::install_github("alecuba16/RMySQL")

PD: In windows you have to install RTOOLS before.

from rmysql.

Perfect - thanks!

from rmysql.

This also affects mariadb=10.2.* (on Gentoo)

from rmysql.

I spent an hour or so trying to install RMySQL and re-discovered the patch suggested here. I can't see how this simple fix can break anything else, so I do hope this can be incorporated in the distribution and save a lot of others a bunch of time!

from rmysql.

Does this now work with the CRAN version 0.10.14?

from rmysql.

@krlmlr works for me now

from rmysql.

@krlmlr not for me

utils.c: In function ‘rmysql_version’:
utils.c:269:40: error: ‘MYSQL_SERVER_VERSION’ undeclared (first use in this function); did you mean ‘MYSQL_PS_CONVERSION’?
   SET_STRING_ELT(output_nms, 0, mkChar(MYSQL_SERVER_VERSION));
                                        ^~~~~~~~~~~~~~~~~~~~
                                        MYSQL_PS_CONVERSION
utils.c:269:40: note: each undeclared identifier is reported only once for each function it appears in
make: *** [/usr/lib64/R/etc/Makeconf:159: utils.o] Error 1
ERROR: compilation failed for package ‘RMySQL’

OpenSUSE Tumbleweed, R 3.4.4, MariaDB 10.2.13

from rmysql.

I'm still seeing this error when building RMySQL (0.10.15) with MariaDB 10.2.8 to provide backend.

Edit: RMySQL 0.10.16 exhibits the same build failure.

utils.c: In function 'rmysql_version':
utils.c:269:40: error: 'MYSQL_SERVER_VERSION' undeclared (first use in this function); did you mean 'MYSQL_PS_CONVERSION'?
   SET_STRING_ELT(output_nms, 0, mkChar(MYSQL_SERVER_VERSION));
                                        ^~~~~~~~~~~~~~~~~~~~
                                        MYSQL_PS_CONVERSION

Seems like @jeroen implied that work done on Feb 25, 2018 (such as 6434882) was intended to fix this issue. That work should be in RMySQL (0.10.15).

Can't the patch suggested in #215 be merged?

CentOS Linux release 7.6.1810, R 3.5.1, MariaDB 10.2.8

from rmysql.