Comments (6)
chyx
commented on September 1, 2024
To be exact, this happens when any one of the value is Inf:
library(scales)
percent(Inf)
[1] "NaN%"
percent(c(1, Inf))
[1] "NaN%" "NaN%"
percent(c(1, NaN))
[1] "100%" "NaN%"
sessionInfo()
R version 3.4.1 (2017-06-30)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 14.04.5 LTS
from scales.
dpseidel
commented on September 1, 2024
fixed by #142
from scales.
hadley
commented on September 1, 2024
I don't think we're using number_format() in percent() yet?
from scales.
dpseidel
commented on September 1, 2024
It's fixed in the precision function in #142.
…On Fri, Jul 6, 2018, 9:32 AM Hadley Wickham ***@***.***> wrote:
I don't think we're using number_format() in percent() yet?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#97 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AP8x6Cq7jqFgMTme3E8RfaGvzaD0IZ64ks5uD5EbgaJpZM4O43-Z>
.
from scales.
dpseidel
commented on September 1, 2024
percent() calls precision() which is where infinite values are now handled. I tested it to ensure it is indeed fixed, but perhaps this will change again in the next PR? I don't expect it to break again though.
from scales.
hadley
commented on September 1, 2024
Oh, got it!
from scales.
Related Issues (20)
- Release scales 1.3.0
- Bug: where reversed global colour & fill aesthetic, and fixed colour in geom HOT 3
- scales: 2 issues
- `label_number` error when including `scale_cut` argument HOT 11
- Feature request: rescale transformation HOT 2
- Feature request: integer breaks
- feature requests: suppress trailing 0s when specifying accuracy and specify maximum number of digits when using NULL argument heuristic
- Add "real" ggplot examples to `label_*()` and `breaks_*()` functions
- Feature request: `label_log()` but for negative numbers
- Feature request: expand suite of colour manipulation functions
- Feature request: `pal_size`, `pal_alpha`, & `pal_linewidth` HOT 5
- Feature request: properties for palettes
- Feature request: `hold` argument for `label_*` functions HOT 1
- Feature request: could scales support keeping oob values but with infinites turned to NA? HOT 2
- Consider including package name in S3 class name(s)?
- Add help for breaks_* functions that says they return a function etc
- Could arguments be added `breaks_extended`, so that it is easier to use?
- Feature - wrap at a specific character
- `breaks_width()` does not work with reverse transform
- Feature request: Could `label_*` functions support labelling every nth break? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scales.