Giter VIP home page Giter VIP logo

Comments (3)

ra1028 avatar ra1028 commented on May 27, 2024

Thank you for your proposal @Marcocanc

As you described, Identifiable and Differentiable have semantically the same properties.
However, Identifiable has OS restrictions, and I think there are few benefits to use it with breaking API.
How about implementing such a simple extension?

public extension Differentiable where Self: Identifiable {
    @inlinable
    var differenceIdentifier: ID {
        id
    }
}

from differencekit.

Marcocanc avatar Marcocanc commented on May 27, 2024

Thanks for the quick feedback. I understand that aligning the API might not be worth breaking existing code bases.

I have created a separate PR (#83) which introduces ContentIdentifiable and removes its dependency from ContentEquatable. Differentiable is now a composed protocol.
This will allow to work with the protocols on a more granular level and avoid any breaking APIs.

from differencekit.

ra1028 avatar ra1028 commented on May 27, 2024

Thanks @Marcocanc

The changes by #83 breaks the existing API, but agrees that it can be further clarified by separating identification and equality, so I'll allow this and include it in the next version 1.2.0.

Whether to change the naming differenceIdentifier to id will be discussed again when DifferenceKit grows to version 2.0.0.

from differencekit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.