Giter VIP home page Giter VIP logo

Comments (5)

ra1u avatar ra1u commented on July 17, 2024

The future chaining that's going on with _future I don't believe will work as expected since when the Future is completed with an error the successor will never be called.

That is good point.

I believe that one possible fix is to wrap return future. We need to keep _future in connection.dart, allays without error and we yield error in future that gets to user.

from redis-dart.

rajmaniar avatar rajmaniar commented on July 17, 2024

I don't really understand what purpose _future serves but what you're suggesting sounds good to me.

from redis-dart.

ra1u avatar ra1u commented on July 17, 2024

_future serves so that we can stack multiple request over same socket and then make repose, to appropriate caller when response is received.
It makes high performance example to work.

I made some modifications. @rajmaniar , can you run some test on your side and report if that improves this issue.

from redis-dart.

rajmaniar avatar rajmaniar commented on July 17, 2024

The changes seem to work well, thanks!

from redis-dart.

ra1u avatar ra1u commented on July 17, 2024

fix released with v2.1.0

from redis-dart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.