Comments (4)
raamcosta
commented on May 12, 2024
Hmm I guess the problem here relates to the usage of DestinationsNavigator, correct?
This is an easy fix, all we need to do is add a method to the DestinationsNavigator interface that receives a Uri and implement it calling the corresponding method in the NavController.
In the meantime, you can simply take the NavController as a parameter to the Composable and that will also allow you to navigate with Uri.
So to be honest I'm torn as to whether or not to implement this method in DestinationsNavigator.
Because I'd like to keep this wrapper as thin as possible. I think for more "exotic" use cases where you really want to be navigating inside your app with deep links (this is the only use case to navigate with a Uri right?) maybe it is ok to depend directly on NavController?
What do you think?
from compose-destinations.
eric-ampire
commented on May 12, 2024
If the code generation is still compatible with the navController then it
can be used but it would be interesting to mention this somewhere in the
documentation so that the user can know in which situation he has to use
the navController or not, because the first reflex is to use the method
from DestinationNavigator : )
…On Wed, 29 Sep 2021, 17:25 Rafael Costa, ***@***.***> wrote:
Hmm I guess the problem here relates to the usage of DestinationsNavigator,
correct?
This is an easy fix, all we need to do is add a method to the
DestinationsNavigator interface that receives a Uri and implement it
calling the corresponding method in the NavController.
In the meantime, you can simply take the NavController as a parameter to
the Composable and that will also allow you to navigate with Uri.
So to be honest I'm torn as to whether or not to implement this method in
DestinationsNavigator.
Because I'd like to keep this wrapper as thin as possible. I think for
more "exotic" use cases where you really want to be navigating inside your
app with deep links (this is the only use case to navigate with a Uri
right?) maybe it is ok to depend directly on NavController?
What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHUIZUORJSITFAKKZ2C2363UEMVYLANCNFSM5FABBS4Q>
.
from compose-destinations.
raamcosta
commented on May 12, 2024
Yes, both are valid as arguments to Destinations.
The wrapper is useful if you want to test or preview these Composables, but you can always just call an overload version of the Composable that only receives lambdas and state.
But you're right that this deserves a mention somewhere. I'll think about it. Thanks for the feedback 👍
from compose-destinations.
raamcosta
commented on May 12, 2024
Updated wiki to mention this, so I'm closing this issue. Let me know if there is actually something else you'd want to see mentioned or fixed.
https://github.com/raamcosta/compose-destinations/wiki/Navigation#navigating
from compose-destinations.
Related Issues (20)
- the topbar is not displaying properly. HOT 1
- the topbar is not displaying properly.
- PopBackStack does not have a check for lifecycle state like navigate does
- String placeholder for deeplink not working HOT 1
- Deeplink pattern
- Nested Graph Problem HOT 5
- popUpTo will not pop up Destination inside NavGraph
- [Security] Repository is vulnerable to MavenGate
- Generated code isn't internal
- Best way to implement / sample code with master-detail for tablets?
- Nested Destination NavGraph with default one being the "deeper HOT 4
- Forbid navigation into subgraphs from other than start destinations of the subgraph
- Compose to Fragment Navigation
- Update to compose navigation 1.7.0-alpha02 HOT 2
- WearOS: Disable swipe-to-dismiss gesture on a destination. HOT 4
- KSP throws error when creating new NavGraphs HOT 1
- Destination for multi module project. HOT 1
- Preserve top-level screens for bottom bar HOT 2
- Crash Caused by android.os.RemoteException while calling navController?.navigate(PipOverlayScreenDestination) HOT 1
- Bottom Sheet Navigation Different Behavior Requirement HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose-destinations.