Comments (3)
Neither. It’s how Compose works in general. Not related with navigation official or this library.
The ViewModel is created as the corresponding screen becomes visible, so I would say you do have control over when it gets instantiated and you should also have control over when it happens on tests. This has never been an issue for me.
As a bonus, the UI shouldn’t be saying things like “load the list” to the VM. The VM is the one that decides what to do.
at most the UI can say “hey the UI is now visible” and then the VM makes the decision to load the list or not.
from compose-destinations.
Hi!
yes, this is expected. When you navigate forward, the back stack entry and the ViewModels are kept but the Composable leaves composition and re enters it when you navigate back. So the LaunchedEffect runs again.
for this use case, what I do usually is I load list on the constructor of the ViewModel. This is better in my opinion for multiple reasons.
from compose-destinations.
@raamcosta Thanks for the quick reply, sorry if it's a bad question, but is this feature of navigation or Compose Destinations?
The problem with loading something in constructor is that you have no control over it, eg in testing - your side effects are started by DI creating the instance, not you.
from compose-destinations.
Related Issues (20)
- Could not find Navigator with name "BottomSheetNavigator". You must call NavController.addNavigator() for each navigation type HOT 5
- Handle different scheme for debug and release build HOT 1
- Deeplink to nested graph destination not working HOT 2
- Build failed: Only safe or non-null asserted calls are allowed for custom `@NavTypeSerializer` HOT 3
- Destination argument names instead of values are passed when values are null HOT 9
- (Open)ResultRecipient seems to cause recompositions HOT 1
- Pass/Access ContentPadding in Child-Destinations HOT 1
- Original Question: Is this project (basically) dead? Answer: Definitely not! Exciting things are coming! HOT 2
- Could not find navigator with name "BottomSheetNavigator" Using compose 1.7 HOT 1
- Please updrade Navigation to 2.8.0-beta05,this version fixed navhost transition stuck issue. HOT 1
- DestinationsNavHost 'start' parameter ruins Multiple Back Stack HOT 6
- "Cannot detect default value for navigation argument" error when updating from 2.0.0-beta09 to 2.0.0-beta10 HOT 4
- Keep previous screen alive HOT 1
- How to handle mutual navigation between multiple modules? HOT 3
- Is there any ideomatic way to navigate to the top level destination? HOT 1
- navArgsDelegate support object inside another class HOT 2
- Is there a way to use ResultBackNavigator in ActivityDestination? HOT 1
- Null Pointer Exception in KSP plugin HOT 1
- dependencyContainer.require go wrong when using muti MutableState<T> as `Arguments from NavHost` HOT 1
- BottomSheet opening delay HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose-destinations.