Giter VIP home page Giter VIP logo

Comments (6)

v0lat1le avatar v0lat1le commented on August 17, 2024

Accidentally posted before fully typing it out. Stand by for more details

from rabbitmq-consistent-hash-exchange.

v0lat1le avatar v0lat1le commented on August 17, 2024

Ok, all deets are there!

from rabbitmq-consistent-hash-exchange.

michaelklishin avatar michaelklishin commented on August 17, 2024

Thank you for filing an issue with some evidence.

You are running 3.7.7, so this is already addressed and proven, see #37. Please upgrade to 3.7.14, you are 10 months behind in terms of releases.

We have integration tests that compute and print Chi square values of the final distribution. A quick check suggests they use string values produced from PRNG-derived numbers.

from rabbitmq-consistent-hash-exchange.

michaelklishin avatar michaelklishin commented on August 17, 2024

Also to be clear, 3.7.7 does not use Jump consistent hashing. That was introduced in 3.7.8, and releaved a few unsafe optimizations in the core that affected this plugin. Those were addressed in subsequent releases and can be found in the change log.

from rabbitmq-consistent-hash-exchange.

v0lat1le avatar v0lat1le commented on August 17, 2024

Ah, sorry for the version confusion! We will consider upgrading to the later version.

The integration test seems to be using list_to_binary(integer_to_list(rand:uniform(10000000))) to generate data where in my tests I was just doing integer_to_list(rand:uniform(10000)). Using list_to_binary does seem to provide much better distribution. Is that something that'll happen to the routing key?

Thanks for the quick reply!

from rabbitmq-consistent-hash-exchange.

michaelklishin avatar michaelklishin commented on August 17, 2024

Routing keys parsed from actual protocol frames are always binaries.

from rabbitmq-consistent-hash-exchange.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.