is it compatible with Chef 12.4 ? about chatops_notify HOT 6 OPEN

I guess at some point we should figure out how we're going to deprecate chef 11.x, keeping existing customers in place with chef-11.x compatible versions, but releasing new versions of these libraries that don't support chef 11.x.

This particular issue definitely feels like a chef 12 thing.

from chatops_notify.

From Chef12.4, it give warning when you are replacing DSL provided by another resource or provider class:

class X < Chef::Resource
  provides :file
end
class Y < Chef::Resource
  provides :file
end

This will emit a warning that Y is overriding X. To disable the warning, use override: true:

class X < Chef::Resource
  provides :file
end
class Y < Chef::Resource
  provides :file, override: true
end

reference:
https://www.chef.io/blog/2015/06/24/chef-client-12-4-0-released/

from chatops_notify.

The chefspec tests currently fail for me (2 failed, 2 total), so I'm not able to reproduce this. @jujugrrr as far as I can tell, this cookbook has no dependencies. I wonder where the other resource that provides :chatops_notify is being loaded from in Chefspec?

from chatops_notify.

I wonder where the other resource that provides :chatops_notify is being loaded from in Chefspec?

The cookbook has 2 providers providing :chatops_notify. https://github.com/rackspace-cookbooks/chatops_notify/blob/master/libraries/provider_chatops_notify_hipchat.rb#L7 https://github.com/rackspace-cookbooks/chatops_notify/blob/master/libraries/provider_chatops_notify_slack.rb#L7

from chatops_notify.

The cookbook has 2 providers providing :chatops_notify

I swear those weren't there before... 👓

from chatops_notify.

should I be worried ?

I think the intended usage here was to always override the resource with a specific provider. Perhaps we should just name these as two different resources & providers, and drop the supports? trick we were using before (since Chef appears to be moving away from that).

from chatops_notify.