Links should open in new tab about django-yarr HOT 5 OPEN

That's a good point; ideally would be addressed by #11, to avoid running it through multiple parsers or risking regexps.

from django-yarr.

Could this be a preference? I prefer the opposite. But of course it should be consistent.

from django-yarr.

Sure, that sounds sensible - it would probably be best to have django consistently spit out the target="blank" everywhere, and then have some javascript strip it out again; that way it can be a per-user and per-device option (for example, I'd prefer new tabs on my phone, but the same tab on my desktop).

from django-yarr.

I absolutely agree it should be a pref, but why use JS instead of doing the processing server-side? To what extent is Yarr supposed to function without JS?

from django-yarr.

I should have said "it would probably be easiest" rather than "best"!

At the moment Yarr is fully functional without JS, but where the JS controls the layout, options are stored in JS cookies. This seemed like an easy way to let me have different defaults on my phone to my desktop, as well as to other users.

As target="blank" isn't a JS enhancement, I agree it would be better to do it server-side. However, I can't see an easy way to do per-user/per-device options without adding a Profile model, either giving users a UI to select and manage sets of options for different devices, or automatically creating a new profile for each new device. While that would work, it feels like overkill, at this stage at least. We can take another look when we have more server-side options to control.

Perhaps a more practical compromise would be to have a global default which controls the generated HTML, then the JS can either add or strip the target based on an option in a JS-managed cookie.

from django-yarr.