Giter VIP home page Giter VIP logo

Comments (6)

MarcSteven avatar MarcSteven commented on June 16, 2024

#26 #27 did this job ,so closed the issue

from coordinator.

radianttap avatar radianttap commented on June 16, 2024

I'm not sure what exactly is gained by splitting the file into two...

from coordinator.

MarcSteven avatar MarcSteven commented on June 16, 2024

@radianttap I think we should conform to SR ,so I refactor this code ,because they are two parts of extension -One is UIViewController and the another one is UIResponder....It's a small change to improve the code.So do you think about importing the framework to make code style well SwiftLint.
How do you think about it ???

from coordinator.

radianttap avatar radianttap commented on June 16, 2024

I strive to follow SR but don't subscribe to it at all costs. Single responsibilty in this case would have been implementation of coordinatingResponder, not simply writing the extensions per type. But I do see your point as valid.

On the topic of SwiftLint, I don't care much about that. I have my habits how I write code, what code I find readable and thus don't care much about anyone's specific style guide :)

from coordinator.

MarcSteven avatar MarcSteven commented on June 16, 2024

Ok @radianttap I won't spend time on this issue ,thank for your info.......

from coordinator.

radianttap avatar radianttap commented on June 16, 2024

Hm, not sure was it clear what I meant: I will accept and merge the pull requests to split the extension into two files. The "don't care much" part was specifically about SwiftLint.

from coordinator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.