Comments (6)
#26 #27 did this job ,so closed the issue
from coordinator.
I'm not sure what exactly is gained by splitting the file into two...
from coordinator.
@radianttap I think we should conform to SR ,so I refactor this code ,because they are two parts of extension -One is UIViewController and the another one is UIResponder....It's a small change to improve the code.So do you think about importing the framework to make code style well SwiftLint.
How do you think about it ???
from coordinator.
I strive to follow SR but don't subscribe to it at all costs. Single responsibilty in this case would have been implementation of coordinatingResponder, not simply writing the extensions per type. But I do see your point as valid.
On the topic of SwiftLint, I don't care much about that. I have my habits how I write code, what code I find readable and thus don't care much about anyone's specific style guide :)
from coordinator.
Ok @radianttap I won't spend time on this issue ,thank for your info.......
from coordinator.
Hm, not sure was it clear what I meant: I will accept and merge the pull requests to split the extension into two files. The "don't care much" part was specifically about SwiftLint.
from coordinator.
Related Issues (20)
- Declarations from extensions cannot be overridden yet HOT 6
- Rewinding state after stop/stopChild HOT 4
- Track `popViewController` when user taps Back bar button on iOS >= 10 HOT 6
- Return back the UINavigationController delegate to parent coordinator when share the UINavigationController HOT 2
- Support Carthage HOT 8
- Support Swift Package manager HOT 2
- Add shields.io badges
- Non-animated pop is not detected in NavigationCoordinator HOT 5
- Bloated Namespace HOT 1
- Unable to compile CoordinatorExample.xcodeproj HOT 2
- How to compile and run the example app? HOT 1
- Cocoapods error HOT 2
- handlePopBack is not called when 2 coordinators share the same rootViewController HOT 3
- Tutorial request - A sample xcproject? HOT 1
- Crash on Accessing Parent Coordinator HOT 3
- Can't use Struct as params in UIResponder's method HOT 1
- Bubbling events in the responder chain HOT 4
- Track Dismissal of RootViewController HOT 3
- UITabBarController as Root or Child Coordinator HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coordinator.