Giter VIP home page Giter VIP logo

Comments (5)

vladmoroz avatar vladmoroz commented on June 12, 2024

This issue is self-inflicted: your spacebar keypress event propagates to the dropdown menu item, which prevents default on click.

The dropdown and dialog should be composed differently to avoid that: #342 (comment)

from themes.

mr-sazzad avatar mr-sazzad commented on June 12, 2024

Dear vlad moroz, I'm unable to access the URL of final updated code into previous solution; could you please verify and provide an updated link?

from themes.

vladmoroz avatar vladmoroz commented on June 12, 2024

@mr-sazzad your code would look like this.

You'd have to make your LoginDialog component controlled and pass open and onOpenChange props into the Dialog inside.

const Profile = () => {
  const [dialogOpen, setDialogOpen] = useState(false);
  
  return (
    <>
      <DropdownMenu>
        <DropdownMenuTrigger asChild>
          <Button
            variant="outline"
            className="rounded-full p-0 flex justify-center items-center overflow-hidden border-0"
            >
            <Avatar>
              <AvatarImage src="../../images/profile.svg" alt="profile-image" />
              <AvatarFallback>AW</AvatarFallback>
            </Avatar>
          </Button>
        </DropdownMenuTrigger>
        <DropdownMenuContent className="w-56">
          <DropdownMenuItem
            className="w-full list-none m-1"
            onSelect={() => setDialogOpen(true)}
          >
            Sign in
          </DropdownMenuItem>
        </DropdownMenuContent>
      </DropdownMenu>
      
      <LoginDialog open={dialogOpen} onOpenChange={setDialogOpen} />
    </>
  );
};

from themes.

mr-sazzad avatar mr-sazzad commented on June 12, 2024

Can i have to remove DialogTrigger from LoginDialog?

from themes.

vladmoroz avatar vladmoroz commented on June 12, 2024

Yeah it's not required in this case

from themes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.