Renaming on windows about watcher HOT 3 CLOSED

Seems to function correctly, thanks :)

from watcher.

Hey @Ewan-Walker,

It seems that this is only now a problem since I rewrote Watcher recently.
I am currently thinking it might be an issue with os.SameFile not working consistently on Windows but I will have to do some investigations.

Thanks for raising this issue. Will have a deeper look in my spare time!

from watcher.

Hey again @Ewan-Walker,

I've implemented a small fix for now, so if you re run go get -u github.com/radovskyb/watcher/... it should be working for windows now.

Like I thought, the issue is that os.SameFile doesn't work consistently across cross platforms, so I'll have to look into that too.

Either way, this fix should work for now :)

I've also noticed my tests fail on windows for chmod events, so I'll have to look into that as well.

Edit: Never mind, I just remembered that os.Chmod isn't supported on windows by Go anyway.

from watcher.