Giter VIP home page Giter VIP logo

Comments (9)

darkopetreski avatar darkopetreski commented on July 20, 2024 1

@RadValentin thank you :)

from postcss-prefix-selector.

jonathanong avatar jonathanong commented on July 20, 2024

i haven't spent a bunch of time into this module. would you like to help maintain it? there might be better modules now.

from postcss-prefix-selector.

valentin-radulescu-hs avatar valentin-radulescu-hs commented on July 20, 2024

This was fixed in #1, you can specify selectors that will be ignored using the exclude option

from postcss-prefix-selector.

valentin-radulescu-hs avatar valentin-radulescu-hs commented on July 20, 2024

@lucasmotta FYI in 1.3.0 @keyframes selectors will get ignored by default, since there's no scenario where they'd need to be prefixed, AFAIK. Hope it helps 😄

from postcss-prefix-selector.

darkopetreski avatar darkopetreski commented on July 20, 2024

I am experiencing the same problem

Here is what I get

@-moz-keyframes shake{
    .the-app 59%{
        margin-left:0
    }
    .the-app 60%,.the-app 80%{
        margin-left:2px
    }
    .the-app 70%,.the-app 90%{
        margin-left:-2px
    }
}

I am using the newest version of postcss-prefix-selector

Here is a segment of the config

const prefixer = require('postcss-prefix-selector');
module.exports = {
  css: {
    loaderOptions: {
      postcss: {
        plugins: [
          prefixer({
            prefix: '.the-app',
            exclude: ['.the-app', '@keyframes', '@-moz-keyframes'],
            transform: function (prefix, selector, prefixedSelector) {
              if (selector === 'html') {
                return 'html' + prefix;
              } else {
                return prefixedSelector;
              }
            }
          })
        ]
      }
    }
  },

am I doing something wrong or the bug is still there ?

from postcss-prefix-selector.

RadValentin avatar RadValentin commented on July 20, 2024

@darkopetreski Thanks for reporting this, I'll look into it tomorrow. It may be due to you using a vendor prefixed selector @-moz-keyframes, a use case that's never been covered by this plugin, it's expected that you'll use autoprefixer in conjunction with postcss. Still, I'm OK with dropping this expectation and making it work right :P

from postcss-prefix-selector.

darkopetreski avatar darkopetreski commented on July 20, 2024

@RadValentin I already have this css generated by other framework and I need to add a prefix in order to use it in an existing cms. Thank you for your effort :)

from postcss-prefix-selector.

RadValentin avatar RadValentin commented on July 20, 2024

@darkopetreski I published a patch to fix the issue, all @keyframes rules should now be ignored by the prefixer. You can drop the '@keyframes', '@-moz-keyframes' part when passing the exclude option. Let me know how it works for you and if you encounter any other issues.

from postcss-prefix-selector.

RadValentin avatar RadValentin commented on July 20, 2024

Forgot to mention, patched version should be 1.7.2

from postcss-prefix-selector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.