Dimensions of Observable(dd) are ignored in Makie 0.21 about dimensionaldata.jl HOT 10 CLOSED

But also something in Makie changed, because it used to work with Makie 0.20 to plot a DimArray even in an Observable{Any}. But Adding a dispatch on Observables{<:AbstractDimArray} should help for now.

from dimensionaldata.jl.

ah the observable type is probably the issue here in terms of dispatch. #720 should make this a non-issue since we would ideally not be relying on argument types at the user level...

from dimensionaldata.jl.

Actually, maybe julia> data = Observable{AbstractDimArray}(dd) would work?

from dimensionaldata.jl.

No that does not make a difference. Also just using Observable(dd) which is of type DimMatrix does nothing.

from dimensionaldata.jl.

We just don't have any dispatch on Observables{<:AbstractDimArray}, basically I just forgot to add it.

from dimensionaldata.jl.

I think that goes back to the expand_dimensions again :D

from dimensionaldata.jl.

yep, see https://github.com/MakieOrg/Makie.jl/blob/b4a92427bbf71bd3e2155bf3a9fc1be18c1ee2d9/src/interfaces.jl#L138-L151

from dimensionaldata.jl.

I made some comments on that PR... I'm not sure the expand_dimensions approach can do half the things we are doing currently

#720 (comment)

from dimensionaldata.jl.

Like its probably worth doing anyway but we might still need our own method dispatch anyway for other reasons

from dimensionaldata.jl.

Looks fixed to me.

from dimensionaldata.jl.