Giter VIP home page Giter VIP logo

Comments (4)

rafaelfranca avatar rafaelfranca commented on June 17, 2024

Is not it missing the erb extension?

from execjs.

chancancode avatar chancancode commented on June 17, 2024

Actually. I know the problem, one of the JSON.generate call is missing quirks_mode: true. (By default it only allows you to make {...} and [...], this flag allows bare strings, numbers, booleans and nulls as well.

We just have to verify it wasn't intentional and add the flag.

from execjs.

chancancode avatar chancancode commented on June 17, 2024

Specifically:

eval "#{identifier}.apply(this, #{::JSON.generate(args)})"

The only thing that is giving me minor doubts is that the original commit that introduced it did it in one place but not the other, but I'm pretty sure it was just a mistake.

from execjs.

lunks avatar lunks commented on June 17, 2024

It has the erb extension. It seems the issue was lingering in the old repo and no one noticed it.

from execjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.