Comments (17)
Google CDN already is updated to 1.8.1.
from jquery-rails.
https://github.com/macovsky/jquery-rails has jQuery updated to 1.8.1. Maybe you give it a try until this is officially updated.
from jquery-rails.
It's coming today.
from jquery-rails.
👍
from jquery-rails.
It would be nice if we could specify what version we wanted to include in our application.js and then the gem would just download the appropriate version from the cdn on assets:precompile. Or, just pass through the path to the cdn file if we don't precompile the assets like in dev mode.
from jquery-rails.
@rcarvalho jquery-ujs supports only specific versions of jquery. The purpose of this gem is to include jquery-ujs and its dependency in the rails app, so it likely won't ever support the ability to pick whatever version of jquery, because we can support all versions of jquery in jquery-ujs.
That being said, you might want to check out the jquery-rails-cdn gem.
from jquery-rails.
@JangoSteve It does support jQuery 1.6 and above according to the header in jquery-ujs. But, I hear ya. Probably not too much advantage to do so. The part which always seems to mess my apps up is deploying to the Heroku environment because assets are compiled on every deploy. So, gem versions that I don't have set at a specific versions and now this jquery version thing breaks my app on a deploy. I'm sure people who are deploying to other environments or precompile their assets by hand don't experience this issue.
Thanks for the jquery-rails-cdn tip. I'll check it out.
from jquery-rails.
I removed jQuery 1.6 support a couple weeks ago, so it hasn't said that since then.
For what it's worth, re: gem version specification, I've recently decided to start versioning jquery-rails as below. I haven't gotten around to updating the README with this yet, but as of v2.1, this is how it works:
patch version bump = updates to jquery-ujs, jquery-rails, and patch-level updates to jquery
minor version bump = minor-level updates to jquery
major version bump = major-level updates to jquery and updates to rails which may be backwards-incompatible
from jquery-rails.
Ahhh, very helpful. So, I could just specify a version of jquery-rails in my Gemfile and then upgrade purposefully (as opposed to unintentionally) when I'm ready to test the new version. Thanks.
from jquery-rails.
So do we need a pull request to get the ball rolling on this? Nice additions, btw.
from jquery-rails.
Alrighty, jquery 1.8.1 shipped with v2.1.2.
from jquery-rails.
Upgrading this gem on our Rails app created some big JS performance issues (IE8). We had to downgrade to v2.1.1.
from jquery-rails.
What kind of performance issues?
from jquery-rails.
On Web pages with heavy, complicated DOM trees, clicking anywhere on the page would cause Internet Explorer 8 to become unresponsive and eventually display, "A script on this page is causing Internet Explorer to run slowly". Tracing it in the developer console was hard (when IE hanged, so did the console), but it looked like the slow code was inside jQuery while trying to search on this selector:
https://github.com/rails/jquery-rails/blob/v2.1.2/vendor/assets/javascripts/jquery_ujs.js#L73
That selector doesn't seem to have changed between 2.1.1 and 2.1.2, so maybe that's a red herring. In any event, downgrading back to 2.1.1 fixed the problem. Other browsers seemed to be unaffected.
Let me know if I should open a separate issue for this.
from jquery-rails.
Hmm. Yeah, that hasn't changed, but what did change was jquery, from v1.8.0 to 1.8.1. It could be a jquery issue.
from jquery-rails.
It is. Read at the bottom of the 1.8.1 release page: http://blog.jquery.com/2012/08/30/jquery-1-8-1-released/
1.8.1 is no bueno.....
from jquery-rails.
Okay, sounds like a jQuery problem. Sorry for the bother.
from jquery-rails.
Related Issues (20)
- url.indexOf is not a function in jQuery.fn.load = function( url, params, callback ) HOT 1
- CVE-2019-5428 HOT 1
- Security issue with jquery 3.4.1 HOT 7
- Issue a security advisory for versions < 4.4.0 HOT 5
- jQuery not loading HOT 3
- jquery-rails with Spockets 4 JS HOT 1
- Dropping `git` in gemspec & using Packaging extension HOT 1
- Update jQuery to v3.6.0 HOT 4
- The Jquery V3.5.0+ already removed trim method.
- Update `jquery-rails` to include new jquery-ujs for better Turbo compatibility HOT 1
- JQuery 3.6.1 released HOT 1
- Rails 7 with importmap HOT 3
- What is the status of v4.5.1 ? HOT 1
- jquery-rails doesn't work correctly in Rails 7 HOT 2
- Drop support for jQuery 1 & 2
- allert does not work HOT 1
- Update jQuery to v3.6.4 HOT 1
- JQuery 3.7.0 released HOT 7
- JQMIGRATE: jQuery.fn.submit() event shorthand is deprecated HOT 1
- jQuery 3.7.1 released HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-rails.