With the new android gradle plugin 3.x it's no longer needed to specify buildToolsVersion about android-buildconfig HOT 6 CLOSED

I see, good to know.
We are not using the NDK currently and have no configuration for it in the shared android config so i'll close this issue for now.
🤘🏼

from android-buildconfig.

which files do you mean? the versions.gradle or android/library.gradle/android/application.gradle?
If you use the versions in versions.gradle for both plugin and app/lib config the versions should be consistent. But it sounds like you use master app/lib config with AGP 3, is that correct?

Currently we have not migrated our SDKs to AGP 3, which is why master still agp 2.3.3 - if you use AGP 3 you can use the agp3 branch, which will be coexisting parallel to master for a bit.

from android-buildconfig.

I was talking about android/library.gradle and android/application.gradle files. The buildToolsVersion is not needed for AGP3

android {
buildToolsVersion CONFIG.versions.android.tools
}
You had a good intuition :), yes I'm using the master branch with AGP 3. (Sorry for the lack of details for the ticket)

I was not aware about the AGP 3 branch I will switch to it, thank you for your quick answer :)

from android-buildconfig.

Also for NDK it’s not needed to pass in the sdk as a macro anymore

from android-buildconfig.

@jcayzac i don't quite get what you mean by "pass in the sdk as a macro" - could you elaborate please?
@scdc Sorry for the late reply. You are right that the build tools are obsolete and don't need to be manually synched by the config after migrating to agp3.
So I'll remove it from the agp3 branch.
As part of this I'm also merging the 1.0.0 cleanup into the agp3 branch - so when you update on your side to the latest agp3 branch beware that versions.gradle & jacaco.gradle moved.

from android-buildconfig.

I mean that defining the ANDROID_PLATFORM (min sdk), ANDROID_TOOLCHAIN (clang) & ANDROID_STL (gnustl_static) C processor macros when configuring Cmake is not required anymore.

from android-buildconfig.