Allow specials that are placed on river terrain to maintain the river/banks when the river is polished at the end of mapgen about cataclysm-dda HOT 1 OPEN

Whaley The Christmas Spirit09/26/2018
Did mapgen get updated to support structures made in the water without a ring of land around it?
On mapgen, not like player constructed
ralreegorganon09/26/2018
not that i know of
Whaley The Christmas Spirit09/26/2018
Just checking, someone was telling me about some weirdness with the riverside structures
ralreegorganon09/26/2018
are those riverside structures set to be placed on river overmap terrain in the definition?
Whaley The Christmas Spirit09/26/2018
Well, it was sort of wacky before, so I had them connect to the shoreline always
It wasn't supposed to be IN the water
just always on the shore
ralreegorganon09/26/2018
what's one of the overmap terrain ids?
shipwreck_river_1 ?
Whaley The Christmas Spirit09/26/2018
riverside_dwelling
Looks like its not connecting to the shore anymore and is just in water
Let me go check my original, someone might have edited it when it was merged, who knows
ralreegorganon09/26/2018
https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/mods/Boats/specials.json#L17
looks like its doing exactly what it was told to do--be placed in water
Whaley The Christmas Spirit09/26/2018
Hm, nope thats exactly what it was in my original too
I'll go mess with it
and see if I can force it onto the shore again
ralreegorganon09/26/2018
your boat rental has a connection to a road terrain
Whaley The Christmas Spirit09/26/2018
instead of lil' islands
I could have sworn I did a riverbank connection
or whatever the river edge is called
ralreegorganon09/26/2018
"water" locations are
{
"type": "overmap_location",
"id": "water",
"terrains": [
"river",
"river_center",
"river_c_not_ne",
"river_c_not_nw",
"river_c_not_se",
"river_c_not_sw",
"river_ne",
"river_se",
"river_sw",
"river_nw"
]
},
i believe all of those but "river_center" are basically shoreline
it might be that you should define a new overmap location called "river_bank" or something of the sort, and have the specials use that rather than "water" as the allowed location
and that location would include all the terrains above except "river_center"
Whaley The Christmas Spirit09/26/2018
I think I tried that before and it was more jank, but who knows. I'll take another look at it
ralreegorganon09/26/2018
those riverbanks are all part land, part water, so depending on how your mapgen looks, it may be kinda silly
ralreegorganon09/26/2018
e.g. if it's all land in your mapgen, then you'll have this bit of land jutting out in the water
alan09/26/2018
hrmmm. so heat blisters can trigger at 111F? that seems super low
Whaley The Christmas Spirit09/26/2018
Also, even if you put water there, the mapgen will force a new ring of land around it
about 2 or 3 tiles wide
alan09/26/2018
i'd say 120F+ would be heat blister territory
ralreegorganon09/26/2018
eh, i'd have to look into that one
Whaley The Christmas Spirit09/26/2018
Thats why you can't make docks
Water is just wacky.
ralreegorganon09/26/2018
you're saying if you define a mapgen that is
LLLWWW
LLLWWW
LLLDDW
LLLWWW
LLLWWW

and tell it to place that only on a west riverbank, which normally mapgens like:
LLLWWW
LLLWWW
LLLWWW
LLLWWW
LLLWWW

it'll add extra land on the east, north and south sides where you said it water?
Whaley The Christmas Spirit09/26/2018
It will force a new riverbank on the first tile outside that ones 24x24 tile
so LLLWWWLLW
ralreegorganon09/26/2018
hmm, that sounds like maybe the code that neatens up rivers is seeing that there is NOT a "river" i that location anymore, and thus makes a bank
Whaley The Christmas Spirit09/26/2018
Yup
ralreegorganon09/26/2018
that seems fixable to me
Whaley The Christmas Spirit09/26/2018
We need a overmap_terrain flag or something
["IS_RIVER"]
or some shit
ralreegorganon09/26/2018
right
Whaley The Christmas Spirit09/26/2018
That also doesn't see it as a CONTINUATION of a river
Whaley The Christmas Spirit09/26/2018
or else you get weird water flowing around it I bet
ActuallyThatKevin09/26/2018
Re: rivers there also the issue where you want your terrain to be immediately adjacent to water, like a dock
I think the mapgen cleanup code sabotages that
ralreegorganon09/26/2018

hmm, that sounds like maybe the code that neatens up rivers is seeing that there is NOT a "river" i that location anymore, and thus makes a bank
^
it's the polish_river that walks the whole thing and does the transformations

from cataclysm-dda.