Error with the printf arguments about coding-standard HOT 6 CLOSED

Your PR looks great. Thanks!

By the way the hook for the pre-commit are a bit strange for the descriptionEndMark value

Thanks for the feedback. I'll see what I can do to make this less confusing.

from coding-standard.

What is the error message?

from coding-standard.

I just looked at the docs, and I think you're correct. I'm curious why I've never noticed a problem. 🤔

Feel free to submit a pull request. I can help with this, if you like. Otherwise, I'll try to get it fixed in the next week or so.

Thanks!

from coding-standard.

Yes it's strange you never see the problem. I have made a quick test in php7.4 and php8 and in php7.4 it display a warning, and in php 8 it throw a fatal error.

Warning: printf(): Argument number must be greater than zero in...
Fatal error: Uncaught ValueError: Argument number must be greater than zero in...

I will submit a PR in a few hours.

from coding-standard.

Thanks!

from coding-standard.

I have created the PR. Tell me if it's ok.

By the way the hook for the pre-commit are a bit strange for the descriptionEndMark value. It's empty so it mean there should not have a ponctuation character at the end of the description. It's not really clear the character ")" is considered as a punctuation. I got an error on the message "fix: blablabla in the function printf()" but not a lot of information for the error. But removing the trailing "()" allowed me to commit the message. Hope i am clear english is not my mother tongue.

from coding-standard.