Giter VIP home page Giter VIP logo

Comments (3)

yasker avatar yasker commented on May 19, 2024 2

Seems we should add an image pull secret option in the cmdline.

from local-path-provisioner.

hwaastad avatar hwaastad commented on May 19, 2024

@yasker this would be a minor change I think by extending the podpec in provisioner.go:

ImagePullSecrets: []v1.LocalObjectReference{
				{Name: p.pullSecret}, // should be loop of spec.imagepullsecrets
			},

We have met this issue our self having to use a private docker proxy.
I can add a PR for this one, but in my simple impl (since I have a limited knowledge of the go-client) I've added a pullproxy option to the provisioner (similar to the --helper-image). (Would probably be best if it was injected from the spec.imagepullsecrets from deployment,if possible)

from local-path-provisioner.

vincent-herlemont avatar vincent-herlemont commented on May 19, 2024

If the PR #119 is merged, this issue shouldn't be closed?

from local-path-provisioner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.