Comments (1)
According to vscode docs our dispose()
handler should be called when table view tab is closed, but we never get there:
https://code.visualstudio.com/api/extension-guides/webview#lifecycle
See onDidDispose()
added: https://github.com/RandomFractals/tabular-data-viewer/blob/main/src/views/tableView.ts#L148
// dispose table view resources when table view panel is closed by the user or via vscode apis
this._webviewPanel.onDidDispose(this.dispose, null, this._disposables);
}
/**
* Disposes table view resources when webview panel is closed.
*/
public dispose() {
console.log('tabular.data.view:dispose(): disposing table view:', this._fileInfo.fileName);
TableView.currentView = undefined;
TableView._views.delete(this.viewUri.toString(true)); // skip encoding
this._webviewPanel.dispose();
while (this._disposables.length) {
const disposable: Disposable | undefined = this._disposables.pop();
if (disposable) {
disposable.dispose();
}
}
// clear and hide current table view stats display
statusBar.hide();
}
from tabular-data-viewer.
Related Issues (20)
- Package and publish https data files loading release HOT 1
- Document tabular-data-viewer commands HOT 1
- Create built-in Data Packages picker HOT 5
- Update vscode dev dependencies to the latest v1.64.0
- List tabular data resources for a data package HOT 1
- Add Data Packages sidebar views HOT 1
- Use active text editor document Uri for View Table command
- Add Open Text Document command and context menu options for data files displayed in Table View HOT 1
- Add View Data File on GitHub command and context menus for Table views with public datasets from github HOT 1
- Move commands registration from src/extension.ts to src/commands/commands.ts
- Package and publish Uri handler and Data Packages support release HOT 1
- Add Charts section to README.md
- Add Flat Data Grid view option
- Update dependencies and vscode extension dev libraries to the latest v1.66
- Enable Tabular data views to work on github.dev and in the web version of vscode IDE
- Update Tabulator to v5.1.8
- Update Perspective view libraries to the latest v1.3.6
- Use shields.io for version, installs, and downloads badges in docs HOT 1
- Use table icon for View Table context menu in open CSV files HOT 1
- Refine tabular data loading errors HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tabular-data-viewer.