Axlsx doesn't escape strings properly about axlsx HOT 9 CLOSED

You cannot use &, <, or > in xml. - they must be character entities.

I don't think it should be the responsibility of the gem to try and guess when "&" is supposed to be converted to &

from axlsx.

I think it axlsx should convert them to entities, in excel I don't have to worry about entities or xml. Why should I have to when I use axlsx ;). It did convert them before those performance tweaks.

from axlsx.

Care to take this one on? I am a little bit worried about the performance hit of checking the content of every non-formula string cell to ensure that it does not contain invalid XML characters.

from axlsx.

On my system escaping is 19% slower.. But IMHO it must not be possible to generate invalid documents using axlsx.
:)

from axlsx.

What kind of mechanism are you using?

from axlsx.

I tried fast_xs and CGI.escapeHTML using a simple collect before calling add_row

from axlsx.

hmmm we are going to have to eat this somewhere. Looking at the fastest option (replacing in worksheet.to_xml_string) is complicated - seems it should happen when the cell is created. (as you have done with add_row) Do you know a way to hit libxml directly? (again my ignorance shines through...)

feeling parenthetical it seems...

from axlsx.

fixed on master and will be released with 1.1.0
I used CGI in Cell.cast_value as it only applies to strings and need to be hit when people edit the value of the cell directly.

from axlsx.

👍

from axlsx.