null handling about fast-excel HOT 9 CLOSED

It is fixed. You are super cool.

from fast-excel.

Thank you!

from fast-excel.

@rap2hpoutre I am using the latest nuget package and it seems this issue is happening again?
if a cell is blank then the cell is not being included in the cells enumeration for that row at all?
how has this regressed if there is a test for it?

from fast-excel.

Thank you for your contribution. Could you please provide a (small) example of an Excel that produce the bug? I could add it to the unit tests and fix the bug!

from fast-excel.

When there are nulls values the null cells are skipped (or better missing) end the rest of the line is shifted to the left.

file-3.xlsx

from fast-excel.

I can not reproduce the problem. I tried this but it's OK (no bugs):

$original_collection = collect([
    ['col1' => 'val1', 'col2' => 'val2'],
    ['col1' => null, 'col2' => 'val2'] // <= the "null" value is here. 
]);

$filename = __DIR__ . '/test2.xlsx';

(new FastExcel($original_collection))->export($filename);
$res = (new FastExcel())->import($filename);

$this->assertEquals($original_collection, $res); // <= My unit test is green, success

unlink($filename);

Could you paste a relevant part of your collection (thank you for your time!)?

from fast-excel.

this is my example (full of nulls):
code.txt

from fast-excel.

Thank you! Fixed via b8f3fec, available in v0.4.0 (just update your version with composer and it should work!). Let me know if something went wrong!

from fast-excel.

Also, I added a unit test with your case, thanks to you:

from fast-excel.