Giter VIP home page Giter VIP logo

Comments (4)

lambertkevin avatar lambertkevin commented on June 2, 2024

Ok turns out we were missing one parameter in the injectIntoDevTools function of the renderer. Without 'version', it returns a production buildType instead of development.

I'll do a PR to fix this.

EDIT: Hmm looks like I fixed the builType but the devTools still don't work, I still get the "waiting for roots to load..." error message...

from react-tv.

raphamorim avatar raphamorim commented on June 2, 2024

it's missing version key here: https://github.com/raphamorim/react-tv/blob/master/packages/react-tv/renderer/ReactTVFiberEntry.js#L274

from react-tv.

raphamorim avatar raphamorim commented on June 2, 2024

It's failing even setting the version? @KevinMolotov

from react-tv.

lambertkevin avatar lambertkevin commented on June 2, 2024

Hi @raphamorim! I added the missing version property but it only fixes the prod/dev issue where the devtools thought they were always in a production build. But we still get this message https://i.imgur.com/GgUwenK.png.

I tried to switch the renderer with react-dom on the same project and the devtools works perfectly. Tried to update react-reconciler to check if the problem was coming from it, but there is too many breaking changes between the 0.10.0 and even the 0.11.0... And they're in 0.16.0 now.
Don't you have the same issue on your side?

EDIT: Well strangely, today it's working... I spent way too much time on this to like it being resolved by black magic 😝

from react-tv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.