Giter VIP home page Giter VIP logo

Comments (7)

mdevan avatar mdevan commented on June 12, 2024

Agree.

Ideal approach would be to move the collection part into a package like github.com/rapidloop/pgmetrics/collector, and use that from the command-line tool in github.com/rapidloop/pgmetrics/cmd/pgmetrics.

from pgmetrics.

siddharth178 avatar siddharth178 commented on June 12, 2024

Good to know that you are open to make this. Let me see if I can come up with something on these lines.

from pgmetrics.

siddharth178 avatar siddharth178 commented on June 12, 2024

Here is another attempt to get this working.
#15

from pgmetrics.

siddharth178 avatar siddharth178 commented on June 12, 2024

@mdevan, did you get chance to look at new PR? if its looking ok, will it be possible to get this merged soon? I am happy to do any more cleanups that you might be thinking of in may be another PR?

from pgmetrics.

mdevan avatar mdevan commented on June 12, 2024

Sorry for the late reply. Some comments in #15.

from pgmetrics.

mdevan avatar mdevan commented on June 12, 2024

Merged and available in master with 25a1800.

from pgmetrics.

siddharth178 avatar siddharth178 commented on June 12, 2024

awesome! thanks. 👍

from pgmetrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.