[TASK] [DEBT] Use GLOG in the cuML's back-end about cuml HOT 8 CLOSED

@jrhemstad I didn't notice anywhere it being mentioned that we can mix logger objects from different logging libraries itself? Maybe I'm misreading its docs?

You can mix logger objects because the libraries are totally independent. The spdlog that is in librmm.so is totally independent of libcuml.so.

Furthermore, the logger object I'm using in RMM isn't registered with spdlog's global registry of loggers because I don't want it to be visible or used externally. So there is no way you can possibly interact or conflict with the logger used in RMM short of totally rewriting the code.

from cuml.

Sometime ago I worked in things relative to append logging infrastructure to RAPIDS:

Repository:
https://github.com/burlachenkok/cuml/commits/Work_on_RAPML_29

Change:
burlachenkok@5dc14b9

from cuml.

Marking this as a Tech Debt item so as to help as plan for future clean-up releases.

from cuml.

@jrhemstad has recently filed a PR under RMM proposing to use spdlog as the underlying logging library.

Since we depend on RMM, we should do either one of the following:

1. check if we can safely mix loggers, in case we want to go ahead with glog
2. use spdlog instead of glog

Personal opinion: I'd favor spdlog.

from cuml.

I looked at glog and didn't like it because it wasn't header only. That's less of a big deal for a compiled library like cuML. This was more important for RMM since we're planning to make it header only.

See https://github.com/gabime/spdlog/wiki/How-to-use-spdlog-in-DLLs about mixing loggers in different libraries. They shouldn't collide at all.

from cuml.

@jrhemstad I didn't notice anywhere it being mentioned that we can mix logger objects from different logging libraries itself? Maybe I'm misreading its docs?

from cuml.

Great. Thanks for the confirmation @jrhemstad

from cuml.

Closing this one as PR #1867 has now been merged.

from cuml.