[BUG] DBSCAN results incorrect about cuml HOT 8 CLOSED

branch-0.5 should be compared against 0.4 release.

from cuml.

what is [1]?

from cuml.

Updated original comment

from cuml.

I ran @daxionshu's notebook against branches 0.5, 0.4, 0.3. This means this has been broken since before the refactor.

I believe the sklearn toy datasets should be tested even on the C++ side. That way when results don't match it's very clear to see which layer bugs were introduced.

from cuml.

@teju85, have you gotten a chance to look at this or #63 yet? It looks like a fix for this is slated for 0.5. Referencing #83 to reproduce the problem.

from cuml.

@cjnolet which of these issues against dbscan needs to be prioritized? 54, 63 or 80?

from cuml.

Also, is there a standalone python script that could repro this mismatch? (Sorry, if you have had it somewhere already!)

from cuml.

I’m going to go ahead and close this for now since we have discussed how the subtle differences in eps affect the results.

from cuml.