Giter VIP home page Giter VIP logo

Comments (2)

rapodaca avatar rapodaca commented on August 24, 2024

Points of incompatibility. These are features explicitly defined in one or the other paper, but which are different in Dialect:

  • new element symbols: Db; Sg; Bh; Hs; Mt; Ds; Rg; Cn; Nh; Fl; Mc; Lv; Ts; Og
  • disallowed element symbols: Ha
  • disallowed symbol , (JCICS)
  • disallowed charges: --; ++; +++; etc.
  • disallowed bonds: :
  • double branching is disallowed, e.g.: *((*))*; *(((*)))*; etc.
  • reactions are disallowed, e.g.: *>>*
  • all stereo descriptors except @ and @@ are disallowed
    • e.g., @@@ and @@@@ (note recursion in grammar)
    • @1
    • @AL2, @AL2, @SP1, etc.
  • hydrogen is just another bracket atom
    • [HH] is valid as are [HH2] and other chemically nonsensical constructs. Contradicts JCICS.
  • . is NOT a "bond of formal order zero" (p 88, bottom). It is not a bond at all. . This point is contradicted elsewhere, so must be clarified.
  • integer values restrictions (previously no upper bound)
    • isotope: 0 < value < 1000
    • charge: 0 < value < 10
    • hcount: 0 < value < 10
    • map: 0 <= value < 999

Points not explained by either paper, but in Dialect:

  • computing implicit hydrogen
    • on a selected atom
  • selection algorithm
  • deselection algorithm
    • pruning
  • LL(1) formal grammar

Contradictory points resolved in Dialect:

  • table of default valences
    • 1988: N(3)
    • 2003: N(3,5)
  • membership of organic subset
    • H is NOT in the "aromatic subset." See Hn1cccc1, JCICS p 35 bottom left, contradicts p32 top right.
  • atom selectability
    • 1988: implies "aromatic cycles" only, although in a contradictory way
    • 2003: examples of acyclic selections

from dialect.

rapodaca avatar rapodaca commented on August 24, 2024

Table of differences:

Feature SMILES Dialect
element symbol Ha accepts rejects
element symbols Db; Sg; Bh; Hs; Mt; Rg; Cn; Nh; Fl; Mc; Lv; Ts; and Og rejects accepts
future element symbols approved by IUPAC rejects accepts
comma symbol (,) may accept rejects
multiple branching e.g., *((*))*) accepts rejects
reactions using greater than symbol (>) accepts rejects
extended stereodescriptors e.g., @@@, @@@@, @AL1, @1, and @SP1 accepts rejects
use of stereodescriptors on odd cumulene centers accepts rejects
virtual hydrogen count on hydrogen probably rejects accepts
detachments are bonds of "formal order zero" probably accepts rejects
upper and lower bounds on atomic properties rejects accepts
nitrogen default valence includes 5 partially accepts accepts
unbracketed hydrogen atom partially accepts rejects
acyclic atom selection partially accepts accepts

from dialect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.