Giter VIP home page Giter VIP logo

Comments (8)

tehguitarist avatar tehguitarist commented on June 18, 2024 1

.m4b should also be entirely fine (which is likely more common than .m4a for audiobooks).

from shelfplayer.

noneme avatar noneme commented on June 18, 2024 1

Thank you! the fact that any modification requires some time for analysis and implementation is normal and correct! especially since this is not a critical moment and may have low priority.

from shelfplayer.

rasmuslos avatar rasmuslos commented on June 18, 2024 1

I don’t suppose there’s a way to pull extension information when downloading the file is there?

Its not that hard, I was doing this because it is way easier and the code is less complex, but because it does not work I will do just that

from shelfplayer.

rasmuslos avatar rasmuslos commented on June 18, 2024

This is actually a pretty stupid hack to make AVPlayer play downloaded tracks. It does not want to play files without an extension but it works fine when it the extension is wrong. Or so I thought. I will look into that and do some testing with m4b files, but fixing this could take some time

from shelfplayer.

rasmuslos avatar rasmuslos commented on June 18, 2024

It seems like using the wrong extension is fine as long as the file type is roughly the same, I guess m4a uses a different decoder then flac/mp3/... I have to rewrite some parts of the download logic to fix this, but thanks for pointing this out!

from shelfplayer.

tehguitarist avatar tehguitarist commented on June 18, 2024

I don’t suppose there’s a way to pull extension information when downloading the file is there?

from shelfplayer.

rasmuslos avatar rasmuslos commented on June 18, 2024

I am currently restructuring ShelfPlayerKit which includes reworking the download logic to some extend, so I will store the file extension in the database which should solve this issue

from shelfplayer.

rasmuslos avatar rasmuslos commented on June 18, 2024

This should be fixed in the latest release v2.0.7 (cc34fd4)

from shelfplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.