Giter VIP home page Giter VIP logo

Comments (3)

ratal avatar ratal commented on August 15, 2024

Thanks a lot for this proposal. I commited modifications from your pull requests.
Please have a look if expected perfomance improvement is ok for you (without yet lazy initialisation)

from mdfreader.

mattispasch avatar mattispasch commented on August 15, 2024

This has a 100x (literally) bigger influence than the lazy initialisation idea.
Since the project I fixed the performance for is already finished, there is no further opinion on my side ;-)
I just wanted you to receive those improvement as you helped me a lot by providing your software as open source - thanks!

from mdfreader.

ratal avatar ratal commented on August 15, 2024

This was a good idea to propose to use set for improving performance, thanks.
If you are satisfied with it, I would prefer to avoid the lazy initialisation. As you mentionned, could be risky for multithreading and even without this consideration, it brought couple of issues with export functions ; for instance calling units that are not existing after closing the file, etc. I could add mechanisms that wil reopen the file but seems complicated/not robust for benefits I cannot graps for the moment.

from mdfreader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.