Add a DocumentStore.Builder about ravendb-jvm-client HOT 6 OPEN

Hi,

@cmitchell Thanks for you suggestion. I really appreciate it.

Please have a look at this issue: https://issues.hibernatingrhinos.com/issue/RavenDB-19938/Redesign-client-API-around-creation-of-database.

It is c# "version" of this one.

As a part of RavenDB culture we are trying to keep API between different languages as close as possible to each other. We live in times when we choose technology/language to solve the problem. Smooth learning curve helps in easy transition between languages.

What do you think about submitting PR to ravendb/ravendb repository with DocumentStore builder? Not sure, if you already had a chance to play with C#, but it might start of very interesting adventure.

from ravendb-jvm-client.

I'm a little confused - are you asking me to make 2 PRs, one for the jvm client and one for the c# code? I've never touched c# so I would at least like to submit the first PR against the java client first so I could incorporate any feedback you might have. Then it would be easier for me to transfer code that I know you like to c# and then put up a PR for the c# code. I would understand if you decided not to merge the jvm PR until the c# work is also done so that you could keep the two code bases in line. That would also motivate me to do it in the c# code so that I could see it on the java side quicker :)

Also, I see the c# ticket was opened 3 weeks ago. Is someone already working it? Submitting the jvm PR first could serve as a reference to someone who already knows c# if someone is working or wants to work the c# ticket you linked to.

from ravendb-jvm-client.

We sync changes from c# client to other by reviewing git diff from latest sync points. With such approach we easily port all features and assure it is in sync. So there is no need for you to submit PR to Java. You can play with c# directly (and sync will be done after some period of time in batch along with other changes).

No one with working on that ticket right now, so if you don't mind feel free to submit your PR.

Personally I was Java developer and they I tried c#, so right now I know both and I don't regret. This is perfect opportunity to gather experience in your professional carrier. :)

from ravendb-jvm-client.

Oh, my bad. The pasted link is for creating new database, but you was referring to DocumentStore. Sorry for that.

As result feel free to create such builder in Java (and ignore c#) and let's leave original version to keep combability.

from ravendb-jvm-client.

I've read the contribution guidlines and signed the CLA. The guidelines say I need to reference a ravendb ticket in my commit message(s) so should I use this issue, #66, or the one you linked to, [RavenDB-19938] )?

from ravendb-jvm-client.

@cmitchell Please use this issue as reference:
https://issues.hibernatingrhinos.com/issue/RDBC-678/Add-a-DocumentStore.Builder-in-Java-client

from ravendb-jvm-client.