Comments (7)
Jeffwan
commented on May 18, 2024
I will keep this open. @feilengcui008 helps add linter and we still need to check fmt and goimports. If there's a difference, we should block the PR.
from kuberay.
Jeffwan
commented on May 18, 2024
/cc @wilsonwang371
from kuberay.
wilsonwang371
commented on May 18, 2024
Is this bug done?
from kuberay.
Jeffwan
commented on May 18, 2024
@wilsonwang371 which bug?
from kuberay.
Jeffwan
commented on May 18, 2024
golint has been marked as deprecated in golangci-lint. Above screenshot is not that helpful anymore. Default linter is good enough. golangci/golangci-lint#1892
from kuberay.
Jeffwan
commented on May 18, 2024
There're lots of failures after we enable linter against apiserver and cli.
from kuberay.
Jeffwan
commented on May 18, 2024
Those issues have been fixed in #158
from kuberay.
Related Issues (20)
- Deprecation of the V1 support for serving has broken API server, that was relying on it
- [Feature] Allow TTL configuration of RayJob submitter job
- Remove Extra Delay for Zero Downtime Rollout Test
- AttributeError: 'Middleware' object has no attribute 'options' HOT 4
- [Test] Add RayJob + Kueue e2e tests HOT 3
- [Feature][RayJob] Redefine RayJobStatus.EndTime HOT 3
- [Feature][RayJob] Set the environment variable `FQ_RAY_IP` for the submitter Kubernetes Job HOT 3
- [Feature] Add default volumes and volumeMounts for `/tmp/ray` to Ray Pods HOT 7
- [Feature] serve run and serve deploy question HOT 2
- [CI] [Bug] e2e sample YAML test pipeline is broken with Docker image hash mismatch HOT 15
- [RayJob] Add tests for #1855 HOT 1
- [Docs] Add docs for structured config and default sidecar containers HOT 1
- [Feature] GPU Support Allow setting runtimeClass in template.spec HOT 1
- [Bug] Long Route names and namespaces auto-generate invalid host
- [Feature] Support AWS IAM for Redis Auth HOT 1
- [Feature] What is kuberay's roadmap for 2024 ? HOT 2
- [Docs] Add example docs of using RayJob and Kueue HOT 4
- [Doc] RayJob `suspend`
- [Feature] Make RayJob recover automatically from K8S submitter job and Ray cluster head node failures HOT 2
- test
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kuberay.