Deion Ray users are creating helper functions similar to <co

[Core] shall we document `__ray_call__` as a public API? about ray HOT 2 OPEN

Atry commented on June 12, 2024

[Core] shall we document `__ray_call__` as a public API?

from ray.

Comments (2)

elainechan01 commented on June 12, 2024

Hey there, I'm interested in contributing to this issue as a first-time contributor. I would love to learn more about this issue to better understand how I can help out. Any additional context you can provide would be greatly appreciated.

Are we referring to this method?

ray/python/ray/actor.py

Line 190 in 040b736

def __call__(self, *args, **kwargs):
Are we aiming to convert this method into a public method or are we just updating the docs?
- If we're converting the method into a public method, are there any items I should be aware of e.g., decorators to include etc.

Thank you!

from ray.

Atry commented on June 12, 2024

On Wed, May 29, 2024 at 8:32 PM Elaine ***@***.***> wrote: Hey there, I'm interested in contributing to this issue as a first-time contributor. I would love to learn more about this issue to better understand how I can help out. Any additional context you can provide would be greatly appreciated. - Are we referring to this method? https://github.com/ray-project/ray/blob/040b736e5fc4f731a3ffd971048e9bd66984cfe2/python/ray/actor.py#L190

No. It should be a monkey patch at https://github.com/ray-project/ray/blob/c94140a3a4b8ae9c0e6f1965d6285161189f9851/python/ray/actor.py#L1643

…

- Are we aiming to convert this method into a public method or are we just updating the docs? - If we're converting the method into a public method, are there any items I should be aware of e.g., decorators to include etc. Thank you! — Reply to this email directly, view it on GitHub <#45068 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAES3OUVJZQB6OELSNPORKDZE2MWNAVCNFSM6AAAAABHBOU6KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGYYTANZYGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

from ray.

Recommend Projects