update vdom dependency about mercury HOT 7 CLOSED

Yes please +1!

There's a bug in the current mercury vdom with diffing attributes that breaks everything (at least for me).

Matt-Esch/vdom@a6c1691

Also @ahdinosaur you should update your pull request to the latest releases (with the bug fixed).

from mercury.

@mmckegg: btw, @pfraze made a new pull request (#91) using the latest vdom for that same bug.

from mercury.

@mmckegg is that commit broken, or does that commit fix the bug.

the attributes object never worked previously.

from mercury.

Sorry, it wasn't attributes that I was after, I got confused by the commit message. The commit also fixed the bug I was facing.

patchObject was missing the declaration of previousValue (see commit before fixed https://github.com/Matt-Esch/vdom/blob/8e0ba4b89257ba4ee2e33df085d857ba78e52db8/apply-properties.js#L47) and was added in the commit I specified above (https://github.com/Matt-Esch/vdom/blob/a6c1691cc4b76d61b7f015ec049627658614fded/apply-properties.js#L49).

Edit: actually now that I'm reading the code properly, it looks like it was attributes that I was after. Sorry for being confusing.

from mercury.

@mmckegg let me ask it differently.

Is mercury broken or is it missing a feature ?

from mercury.

It was missing a feature, but due to a confusing error message, I thought it was a bug.

The old patchObject implementation was incomplete, and would always throw an error when called a second time on the same property.

from mercury.

I updated vdom.

from mercury.