Comments (6)
Implemented in commit c9d22c7
Still some work required to improve new struct Material
usage...
from raylib.
Directly related to issue #96
from raylib.
Standard Material/Lighting system update 01: c60cc9e
Standard Material/Lighting system update 02: 80eb4f3
from raylib.
Answering 9811a37 commit description: "It seems there are some problems with DrawLights()"
I think DrawLights() is correct. It draws:
- Point light: sphere wires.
- Directional light: it draws a sphere wire in its position and cube wires in target position. To set up a directional light, you just have to set up the direction vector that uses the standard shader by subtract target - position (it's the same position(0, 0, 0) target(0, 1, 0) than position (1, 1, 1,) target (1, 2, 1))... I used that way because I think is more simple and visually easy to understand light parameters (and 3D Max uses that way).
- Spot light: it draws a cone in its position (axis oriented) and a cube wires in target position....
So, I didn't see any problem in DrawLights().
But, I have seen another problem... Sometimes, if I move the lights variables definitions to a different order (using current order of the example works fine), there is a light that is not sent to shader or something because you cannot see its effect in the model. I don't know where is the issue: CreateLight() or SetShaderLights()...
I will review it before adding shader maps feature.
from raylib.
Closed by pull request 4b93349
Many thanks to @victorfisac for his amazing work!
from raylib.
You are welcome @raysan5 . It will be improved over time.
from raylib.
Related Issues (20)
- [rlgl] Software renderer support? HOT 8
- [rcore_desktop] Upon entering fullscreen, uses original window size HOT 6
- [misc] Rename `Is*Ready()` to `Is*Valid()` HOT 34
- [rshapes] Off-by-one difference between DrawRectangleLinesEx and DrawLine/DrawLineV at drawing position. HOT 3
- [rmodels] Black GLB models HOT 6
- [build] Unable to build a Mach-O universal binary with 2 architectures when building from source HOT 3
- [Question] is Raylib compatible with smooth rendering ranging from 60 to 1. HOT 2
- WINBOOL not defined (clang) HOT 1
- [core] RPI Opengl - Wrong DRM connector? HOT 14
- [core] Should functions that receive enum values use the enum as argument type? HOT 5
- [core] Should the defines MAX_* be part of the public API? HOT 5
- [rcore_desktop] Can't get size of the monitor before creating a window HOT 2
- [core] rlImGUI needs a way to consume input HOT 4
- [rcore] Calls to GetRandomValue(min, max) will always return min, if not call to InitWindow() HOT 1
- [core] PLATFORM_DRM rotate screen/window HOT 9
- Maybe possibly Invalid Default Texture? HOT 5
- requesting 5.0.1 version to fix incorrect PROJECT_VERSION in 5.0 HOT 2
- [rtextures] DDS / DXT1, DXT3 and DXT5: unit 0 GLD_TEXTURE_INDEX_2D is unloadable HOT 7
- [rcore] Replay record finish can't stop move (always keydown) HOT 2
- [rcore] The content can't be rendered correctly in fullscreen mode. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from raylib.